Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the capability to run capella reference tests #6415

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Nov 9, 2022

  • added the operations/bls_to_execution_change group to operations that are supported
  • added capella fork support

partially addresses #5680

Signed-off-by: Paul Harris [email protected]

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

 - added the `operations/bls_to_execution_change` group to operations that are supported
 - added capella fork support

 partially addresses Consensys#5680

Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Worth logging a ticket to add block inclusion tests for BLS_TO_EXECUTION_CHANGE once we've implemented the operation pool for them.

@rolfyone
Copy link
Contributor Author

rolfyone commented Nov 9, 2022

added #6414 when I did the PR, but mentioning here just in reference to your request @ajsutton

@rolfyone rolfyone enabled auto-merge (squash) November 9, 2022 23:19
@rolfyone rolfyone disabled auto-merge November 9, 2022 23:29
@rolfyone rolfyone enabled auto-merge (squash) November 10, 2022 00:34
@rolfyone rolfyone merged commit c83805e into Consensys:master Nov 10, 2022
@rolfyone rolfyone deleted the capella-ref-tests branch November 10, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants