Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get new BlindedBlockContents Remote api handler #7031

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Get new BlindedBlockContents Remote api handler #7031

merged 4 commits into from
Apr 18, 2023

Conversation

mehdi-aouadi
Copy link
Contributor

PR Description

Implement createUnsignedBlindedBlockContents in RemoteValidatorApiHandler

Fixed Issue(s)

#7012

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Apr 14, 2023
@mehdi-aouadi mehdi-aouadi added the Epic Deneb Issues required to implement Deneb upgrade label Apr 14, 2023
@mehdi-aouadi mehdi-aouadi changed the title 7012 remote api handler Remote api handler Apr 14, 2023
@mehdi-aouadi mehdi-aouadi changed the title Remote api handler Get new BlindedBlockContents Remote api handler Apr 14, 2023
@mehdi-aouadi mehdi-aouadi force-pushed the 7012-remote-api-handler branch from e5c6666 to dfe6bcf Compare April 14, 2023 19:51
StefanBratanov
StefanBratanov approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

data/provider/src/test/java/tech/pegasys/teku/api/ValidatorDataProviderTest.java Outdated Show resolved Hide resolved
@StefanBratanov StefanBratanov mentioned this pull request Apr 18, 2023
Merged
2 tasks
@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) April 18, 2023 15:54
@mehdi-aouadi mehdi-aouadi merged commit 5b19dac into Consensys:master Apr 18, 2023
@mehdi-aouadi mehdi-aouadi deleted the 7012-remote-api-handler branch April 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees

@mehdi-aouadi mehdi-aouadi

Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehdi-aouadi @StefanBratanov