Add PostAttestationV2 API #8448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
array-type-definition
branch
2 times, most recently
from
8e1b367 to
e7094ad
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added new PostAttestationV2 API endpoint (
/data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/JsonTypeDefinitionBeaconRestApi.java,/data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationV2.java) - Introduced header-based schema selector (
/data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/beacon/MilestoneDependentTypesUtil.java) - Enhanced deserialization for arrays with different item types (
/infrastructure/json/src/main/java/tech/pegasys/teku/infrastructure/json/types/DeserializableOneOfTypeDefinition.java,/infrastructure/restapi/src/main/java/tech/pegasys/teku/infrastructure/restapi/endpoints/EndpointMetadata.java) - Added comprehensive tests for new API and schema selector (
/data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationV2Test.java,/data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/schema/MilestoneDependentTypesUtilTest.java) - Introduced new JSON files for testing and error responses (
/data/beaconrestapi/src/test/resources/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/errorListBadRequest.json,/data/beaconrestapi/src/test/resources/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/postAttestationRequestBodyElectra.json,/data/beaconrestapi/src/test/resources/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/postAttestationRequestBodyPhase0.json)
14 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
...ain/java/tech/pegasys/teku/beaconrestapi/handlers/v1/beacon/MilestoneDependentTypesUtil.java
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
postAttestationRequestBodyELECTRA.jsonfor PostAttestationV2 API testing - Added
postAttestationRequestBodyPHASE0.jsonfor PostAttestationV2 API testing - Ensure deserialization of arrays with different item types
- Verify header-based schema selector functionality
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced PostAttestationV2 API in
data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v2_beacon_pool_attestations.json - Added header parameter 'Eth-Consensus-Version' for version handling
- Supported multiple attestation schemas based on 'Eth-Consensus-Version'
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
mehdi-aouadi
force-pushed
the
array-type-definition
branch
2 times, most recently
from
7f7abcd to
c295f56
Compare
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added PostAttestationV2 API in
data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationV2.java - Implemented header-based schema selection in
MilestoneDependentTypesUtil.java - Added support for arrays with different item types in
EndpointMetadata.java - Introduced
OneOfArrayJsonRequestContentTypeDefinition.javafor complex request body handling - Added IPv6 support in
DiscV5Service.javaandNodeRecordConverter.java
18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added PostAttestationV2 API in
data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationV2.java - Implemented header-based schema selection for attestation deserialization
- Simplified error handling in
MilestoneDependentTypesUtil.java - Removed
listOfmethod fromDeserializableOneOfTypeDefinition.java - Renamed
requestBodyTypeForListtorequestBodyTypeinEndpointMetadata.java
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
2 tasks
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added integration tests for
PostAttestationsV2API indata/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/beacon/PostAttestationsV2IntegrationTest.java - Updated
JsonTypeDefinitionBeaconRestApi.javato usePostAttestationsV2class - Introduced
PostAttestationsV2.javato handle new API endpoint/eth/v2/beacon/pool/attestations - Renamed and updated tests in
PostAttestationsV2Test.javato reflect new API endpoint
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
mehdi-aouadi
force-pushed
the
array-type-definition
branch
2 times, most recently
from
4f1c076 to
4b28766
Compare
2 tasks
mehdi-aouadi
force-pushed
the
array-type-definition
branch
from
4b28766 to
0472e2a
Compare
gfukushima
approved these changes
Aug 1, 2024
...re/json/src/main/java/tech/pegasys/teku/infrastructure/json/types/OpenApiTypeDefinition.java
Outdated
Show resolved
Hide resolved
...n-test/java/tech/pegasys/teku/beaconrestapi/v2/beacon/PostAttestationsV2IntegrationTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
#8424
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog