8424 use attestations v2 #8457
Closed
8424 use attestations v2 #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
mehdi-aouadi
force-pushed
the
8424-use-attestations-v2
branch
from
04b498a to
d04d76f
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
sendSignedAttestationsV2method inbeacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java - Introduced
PostAttestationsV2IntegrationTest.javafor integration tests indata/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/beacon - Added new endpoint
/eth/v2/beacon/pool/attestationsindata/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationsV2.java - Updated
ValidatorDataProvider.javato includesubmitAttestationsV2method indata/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java - Introduced new hidden CLI option
--Xattestations-v2-enabledinteku/src/main/java/tech/pegasys/teku/cli/options/ValidatorOptions.java
29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Outdated, will raise a new PR onces the APIs are merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Rebased on top of #8448
Add a hidden option
--Xattestations-v2-enabledto enable the newPostAttestationsV2APIFixed Issue(s)
#8424
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog