Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers to wrap ibc message variants #254

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Add helpers to wrap ibc message variants #254

merged 1 commit into from
Jul 28, 2021

Conversation

ethanfrey
Copy link
Member

A few helpers that would be nice to have in wasmd

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is passing by reference here an optimization?

@ethanfrey
Copy link
Member Author

Not really an optimization here (although it does avoid a copy). We need a reference in the returned object, so it matches.

@ethanfrey ethanfrey merged commit 9e08842 into main Jul 28, 2021
@ethanfrey ethanfrey deleted the ibc-msg-helpers branch July 28, 2021 21:07
faddat pushed a commit to faddat/go-cosmwasm that referenced this pull request Dec 10, 2021
Closes CosmWasm#10 Implemented files called general_consts.go to all modules that heavly relied on  the duplicated "ClientID : 1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants