Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeff/v2 #48

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Jeff/v2 #48

merged 2 commits into from
Dec 12, 2017

Conversation

jfairchild
Copy link
Contributor

Might need help to deploy this

Copy link
Contributor

@cjcodes cjcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Jason knows how to deploy, but it's just a matter of doing: gulp deploy from the v2 branch after merging in. Easy enough to move to CI One Day™.

However, the endpoint seems to be throwing 500 errors when it cold starts. I just tried it, and it failed the first time, them immediately started working, so I'm assuming the Lambda instance needed to cold start. Something must be fishy in the cold start bit of whatever is powering that endpoint.

@jfairchild
Copy link
Contributor Author

I cannot deploy v2 due to an issue with git commit parsing.

@jfairchild
Copy link
Contributor Author

~/CrisisTrends/node_modules/gift/lib/commit.js:145
      ref1 = /^.+? (.*) (\d+) .*$/.exec(line), m = ref1[0], actor = ref1[1], epoch = ref1[2];
                                                       ^

TypeError: Cannot read property '0' of null
    at Function.module.exports.Commit.actor (~/CrisisTrends/node_modules/gift/lib/commit.js:145:56)
    at Function.module.exports.Commit.parse_commits ~/CrisisTrends/node_modules/gift/lib/commit.js:111:21)
    at ~/CrisisTrends/node_modules/gift/lib/commit.js:71:39
    at ChildProcess.exithandler (child_process.js:189:7)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:920:16)
    at Socket.<anonymous> (internal/child_process.js:351:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:497:12)

@jfairchild
Copy link
Contributor Author

Issue is the gulp-gh-pages module is using an outdated gift module

https://github.com/shinnn/gulp-gh-pages/issues/116

@jfairchild
Copy link
Contributor Author

shinnn/gulp-gh-pages#117

Watching the fix for gulp-gh-pages

@cjcodes cjcodes merged commit 165ba0b into v2 Dec 12, 2017
@jfairchild jfairchild deleted the jeff/v2 branch December 12, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants