Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gift dependency #117

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Update gift dependency #117

merged 1 commit into from
Jul 13, 2018

Conversation

tekd
Copy link
Contributor

@tekd tekd commented Nov 9, 2017

This updates the gift dependency here:
https://david-dm.org/shinnn/gulp-gh-pages#info=devDependencies
which should remedy issue #116.

@DavidLemayian

This comment has been minimized.

@ghost

This comment has been minimized.

@lidianhao123

This comment has been minimized.

@osharpe

This comment has been minimized.

@atesgoral

This comment has been minimized.

@buy

This comment has been minimized.

@serbanghita

This comment has been minimized.

@colinthornton
Copy link

I'm also using @tekd's fork with no issues.

yeshiqing added a commit to yeshiqing/resume-generator that referenced this pull request Dec 22, 2017
since the gulp-gh-pages doesn't update gift dependency for a long time,
I'm use the @tekd's fork as an interim solution.
refrence:
shinnn/gulp-gh-pages#117
notatestuser/gift#96
@melanieseltzer

This comment has been minimized.

@matthewcpaul

This comment has been minimized.

@tekd

This comment has been minimized.

@matthewcpaul

This comment has been minimized.

@dpagini

This comment has been minimized.

@willianjusten

This comment has been minimized.

sfentress added a commit to concord-consortium/cloud-file-manager that referenced this pull request Mar 9, 2018
gift 0.6.x required by gulp-gh-pages is broken:

shinnn/gulp-gh-pages#117

Setting resolutions in package.json will cause yarn to show  warning
about conflicts, but will correctly install the requested version.
Highlights:

* update `gift` dependency to avoid "Cannot read property" errors
* use built-in Stream instead of `readable-stream` npm package
* update ESLint to v5 https://eslint.org/docs/user-guide/migrating-to-5.0.0
* update @shinnn/eslint-config and follow its rules, for exmaple tab indents andmodern ECMAScript features
* switch from istanbul to nyc
@shinnn shinnn force-pushed the update-dependency branch from 23c3ee5 to 612a368 Compare July 13, 2018 00:48
@shinnn shinnn merged commit c317690 into shinnn:master Jul 13, 2018
jfly added a commit to jfly/icons that referenced this pull request Jan 7, 2019
This includes shinnn/gulp-gh-pages#117, which we
need to fix the broken build. Hopefully upgrading doesn't cause any
other issues, for some reason they have not yet marked 0.6 as the
`latest` release on npm.js. See
https://github.com/shinnn/gulp-gh-pages/issues/129 for more information.
jfly added a commit to cubing/icons that referenced this pull request Jan 7, 2019
This includes shinnn/gulp-gh-pages#117, which we
need to fix the broken build. Hopefully upgrading doesn't cause any
other issues, for some reason they have not yet marked 0.6 as the
`latest` release on npm.js. See
https://github.com/shinnn/gulp-gh-pages/issues/129 for more information.
Repository owner locked as resolved and limited conversation to collaborators Jan 8, 2019
Repository owner deleted a comment from coveralls Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.