Skip to content

Commit

Permalink
Qview command line Fix (#5505)
Browse files Browse the repository at this point in the history
* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change
  • Loading branch information
acpaquette authored and chkim-usgs committed Jun 18, 2024
1 parent cfba3fe commit 214c4c6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ release.

### Fixed
- Fixed a bug in QVIEW's Stretch tool where the default min/max type was not an available option [#5289](https://github.com/DOI-USGS/ISIS3/issues/5289)
- Fixed a bug in QVIEW where images would double load if loaded from the commandline [#5505](https://github.com/DOI-USGS/ISIS3/pull/5505)

## [8.2.0] - 2024-04-18

Expand Down
9 changes: 8 additions & 1 deletion isis/src/qisis/objs/CubeViewport/ViewportBuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,14 @@ namespace Isis {
* @return bool
*/
bool ViewportBuffer::working() {
return !p_actions->empty() || !p_bufferInitialized || !p_enabled;
bool hasFillAction = false;
for (auto action : *p_actions) {
if (action->getActionType() == ViewportBufferAction::fill) {
hasFillAction = true;
break;
}
}
return hasFillAction || !p_bufferInitialized || !p_enabled;
}


Expand Down

0 comments on commit 214c4c6

Please sign in to comment.