Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qview command line Fix #5505

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Qview command line Fix #5505

merged 3 commits into from
Jun 4, 2024

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented May 28, 2024

Description

Avoid double image load when opening cubes from command line in qview

Related Issue

N/A

How Has This Been Validated?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@acpaquette acpaquette changed the title Avoid double image load when opening cubes from cmdline in qview Qview command line Fix May 28, 2024
@acpaquette acpaquette merged commit 9e00ae2 into DOI-USGS:dev Jun 4, 2024
chkim-usgs pushed a commit that referenced this pull request Jun 18, 2024
* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change
@chkim-usgs chkim-usgs mentioned this pull request Jun 18, 2024
12 tasks
chkim-usgs added a commit that referenced this pull request Jun 20, 2024
* Added kalasiris to dev meta.yml (#5487)

* Add qview stretch bugfix (#5492)

* Add qview stretch bugfix

* Update changelog

* Fix Failing HiJitter Tests (#5507)

* Fixes proj segfault if a match cube is provided

* Revert mcube back into a pointer and correctly handle it

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Update docs

* Fix meta.yaml formatting

---------

Co-authored-by: acpaquette <[email protected]>
chkim-usgs added a commit that referenced this pull request Jun 21, 2024
* Added kalasiris to dev meta.yml (#5487)

* Add qview stretch bugfix (#5492)

* Add qview stretch bugfix

* Update changelog

* Fix Failing HiJitter Tests (#5507)

* Fixes proj segfault if a match cube is provided

* Revert mcube back into a pointer and correctly handle it

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Update docs

* Fix meta.yaml formatting

* Pin qwt to 6.2.0 or lower (#5503)

---------

Co-authored-by: acpaquette <[email protected]>
chkim-usgs added a commit that referenced this pull request Jun 24, 2024
* Added kalasiris to dev meta.yml (#5487)

* Add qview stretch bugfix (#5492)

* Add qview stretch bugfix

* Update changelog

* Fix Failing HiJitter Tests (#5507)

* Fixes proj segfault if a match cube is provided

* Revert mcube back into a pointer and correctly handle it

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Update docs

* Fix meta.yaml formatting

* Pin qwt to 6.2.0 or lower (#5503)

* Pinned suitesparse to below 7.7.0 (#5528)

* Update code.json date

---------

Co-authored-by: acpaquette <[email protected]>
chkim-usgs pushed a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 26, 2024
* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change
@chkim-usgs chkim-usgs mentioned this pull request Nov 26, 2024
12 tasks
chkim-usgs pushed a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 27, 2024
* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change
@chkim-usgs chkim-usgs mentioned this pull request Nov 27, 2024
12 tasks
Kelvinrr pushed a commit that referenced this pull request Nov 27, 2024
* Adds HRSC support in socetlinescankeywords (#5669)

* Adds HRSC support in socetlinescankeywords

* Add test cube

* Fixed tests

* Converted skypt to a callable app. Converted existing Makefile tests to gtests. Removed existing Makefile tests.  (#5444)

* Converted skypt to a callable app. Converted existing makefile tests to gtest format and removed old makefile tests and data. Addresses #5443.

* Updated contributor list to add Sarah S. Sutton. Addresses #5443.

---------

Co-authored-by: Sarah Sutton <[email protected]>

* Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. (#5600)

* Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. Addresses #5599.

* Modifications to address gtest failures. Also added addtional input parameter error checking to ensure noseam exits prior to generation of temporary files. Finally modified gtests to remove the print.prt file if generated. Addresses #5599.

* The explode application has been refactored to be callable and Makefile test converted to a gtest. (#5590)

* Updated explode application gtest to use DefaultCube fixture instead of cube in isis/tests/data. Addresses #5557.

* Cleaned up includes in default explode gtest. Added history entry to explode.xml. Addresses #5557.

* Updating main.cpp and removed Makefile tests for explode conversion to callable app. Addresses #5557.

* Added CHANGELOG entry for conversion of explode app to callable function. Addresses #5557.

---------

Co-authored-by: Adam Paquette <[email protected]>

* Isisminer has been refactored to be callable and Makefile tests converted to gtest format (#5579)

* Fixed minor misspellings in error messages. Addresses #5516.

* Test data added for isisminer. Addresses #5516.

* Converted isisminer Makefile tests to gtest format. Addresses #5516.

* Converted isisminer application to callable function. Addresses #5516.

* Minor tweak to isisminer csvwriter test. Addresses #5516.

* Added compareCsvLineCustomDelimiter method, specifically for isisminer testing support. Addresses #5516.

* Removed isisminer Makefile tests (replaced by gtests) and updated CHANGELOG reflecting conversion of isisminer to callable app. Addresses #5516.

* Replace isis cube in /isis/tests/data/isisminer/gistest with isd and label files. Minor tweaks to FunctionalTestsIsisminer.cpp. History entry added to isisminer.xml. Addresses #5516.

* Minor changes for conversion of isisminer to callable app. Addresses #5516.

* Had to add data file index.lbl to the .gitignore file for it to be uploaded. Addresses #5516.

* Algebra has been refactored to be callable; old Makefile tests have been converted to gtests and removed. Addresses #5594. (#5597)

* Photrim has been refactored to be callable; old Makefile tests have been converted to gtests and removed. (#5582)

* Photrim has been converted to a callable app. Corresponding Makefile tests have been converted to gtests and removed. Addresses #5581.

* Tweaks to FunctionalTestsPhotrim.cpp. Addresses #5581.

* Bandtrim has been refactored to be callable; old Makefile tests have been converted to gtests. (#5572)

* Bandtrim has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Addresses #5571.

* Update FunctionalTestsBandtrim.cpp

Minor documentation change.

* Updated kaguyasp2ascii to support newer (detached) data (#5568)

* Modified to work with new (detached) data

* Updated changelog

* Allow data specification outside current directory

* Jigsaw csm error message (#5562)

* Added fail-early + error message for csminit'd images without csm solve parameters

* Updated changelog

* Bug fix in noproj to remove persistent temporary lbl file (#5578)

* Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses #5577.

* CHANGELOG entry for noproj bug fix. Addresses #5577.

* Added history entry in noproj.xml. Addresses #5577.

* Remove restrictive validity check in caminfo (#5553)

* Removed preemptive validity check for polygon

* Removed unused import

* Updated changelog

* Qview command line Fix (#5505)

* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change

* Change qt to qt-main

* Update deps and pcl cmake

* Add float.h

* CsmSerialNumber.trn - typo and PVL compilant fix (#5561)

* Fixed typo

* PVL compliant

* PR feedback changes

* hrsc2isis support for level 3 images (#5560)

* Remove label check for level3

* update changelog

* fix test

* addressed PR feedback

* fixed grammar

* Fixed gllssi2isis to support V1.1 data (#5570)

* Removed a debug output statement inadvertently left in noseam.cpp. Addresses #5660. (#5661)

* Bug fixes to address incorrect handling of RADIUS in the jigsaw GUI and in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses #5642. (#5643)

* The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected.

* In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on.

* Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section.

* Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.

* Updated kaguyasp2ascii to support newer (detached) data (#5568)

* Modified to work with new (detached) data

* Updated changelog

* Allow data specification outside current directory

* Speeds up FunctionalTestCamstatsDefaultParameters (#5647)

* speed up camstats

* add changelog

* fixes photomet not accepting backplanes (#5658)

* fixes photomet not accepting backplanes

* fix changelog

* Converted to gtests

* Add input cube attributes

* Convert dstripe to gtests (#5665)

* Convert dstripe to gtests

* add changelog

* Fixed build error

* trigger build

* trigger build

* Update docs

---------

Co-authored-by: Amy Stamile <[email protected]>
Co-authored-by: Sarah Sutton <[email protected]>
Co-authored-by: Sarah Sutton <[email protected]>
Co-authored-by: kledmundson <[email protected]>
Co-authored-by: Adam Paquette <[email protected]>
Co-authored-by: Austin Sanders <[email protected]>
Co-authored-by: Shin-ya Murakami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants