Diagnostic output statement inadvertently left in noseam.cpp #5660
Labels
bug
Something isn't working
Comments
kledmundson
added a commit
to UA-LPL/ISIS3
that referenced
this issue
Nov 7, 2024
12 tasks
amystamile-usgs
pushed a commit
that referenced
this issue
Nov 7, 2024
chkim-usgs
pushed a commit
to chkim-usgs/ISIS3
that referenced
this issue
Nov 26, 2024
chkim-usgs
pushed a commit
to chkim-usgs/ISIS3
that referenced
this issue
Nov 27, 2024
Kelvinrr
pushed a commit
that referenced
this issue
Nov 27, 2024
* Adds HRSC support in socetlinescankeywords (#5669) * Adds HRSC support in socetlinescankeywords * Add test cube * Fixed tests * Converted skypt to a callable app. Converted existing Makefile tests to gtests. Removed existing Makefile tests. (#5444) * Converted skypt to a callable app. Converted existing makefile tests to gtest format and removed old makefile tests and data. Addresses #5443. * Updated contributor list to add Sarah S. Sutton. Addresses #5443. --------- Co-authored-by: Sarah Sutton <[email protected]> * Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. (#5600) * Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. Addresses #5599. * Modifications to address gtest failures. Also added addtional input parameter error checking to ensure noseam exits prior to generation of temporary files. Finally modified gtests to remove the print.prt file if generated. Addresses #5599. * The explode application has been refactored to be callable and Makefile test converted to a gtest. (#5590) * Updated explode application gtest to use DefaultCube fixture instead of cube in isis/tests/data. Addresses #5557. * Cleaned up includes in default explode gtest. Added history entry to explode.xml. Addresses #5557. * Updating main.cpp and removed Makefile tests for explode conversion to callable app. Addresses #5557. * Added CHANGELOG entry for conversion of explode app to callable function. Addresses #5557. --------- Co-authored-by: Adam Paquette <[email protected]> * Isisminer has been refactored to be callable and Makefile tests converted to gtest format (#5579) * Fixed minor misspellings in error messages. Addresses #5516. * Test data added for isisminer. Addresses #5516. * Converted isisminer Makefile tests to gtest format. Addresses #5516. * Converted isisminer application to callable function. Addresses #5516. * Minor tweak to isisminer csvwriter test. Addresses #5516. * Added compareCsvLineCustomDelimiter method, specifically for isisminer testing support. Addresses #5516. * Removed isisminer Makefile tests (replaced by gtests) and updated CHANGELOG reflecting conversion of isisminer to callable app. Addresses #5516. * Replace isis cube in /isis/tests/data/isisminer/gistest with isd and label files. Minor tweaks to FunctionalTestsIsisminer.cpp. History entry added to isisminer.xml. Addresses #5516. * Minor changes for conversion of isisminer to callable app. Addresses #5516. * Had to add data file index.lbl to the .gitignore file for it to be uploaded. Addresses #5516. * Algebra has been refactored to be callable; old Makefile tests have been converted to gtests and removed. Addresses #5594. (#5597) * Photrim has been refactored to be callable; old Makefile tests have been converted to gtests and removed. (#5582) * Photrim has been converted to a callable app. Corresponding Makefile tests have been converted to gtests and removed. Addresses #5581. * Tweaks to FunctionalTestsPhotrim.cpp. Addresses #5581. * Bandtrim has been refactored to be callable; old Makefile tests have been converted to gtests. (#5572) * Bandtrim has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Addresses #5571. * Update FunctionalTestsBandtrim.cpp Minor documentation change. * Updated kaguyasp2ascii to support newer (detached) data (#5568) * Modified to work with new (detached) data * Updated changelog * Allow data specification outside current directory * Jigsaw csm error message (#5562) * Added fail-early + error message for csminit'd images without csm solve parameters * Updated changelog * Bug fix in noproj to remove persistent temporary lbl file (#5578) * Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses #5577. * CHANGELOG entry for noproj bug fix. Addresses #5577. * Added history entry in noproj.xml. Addresses #5577. * Remove restrictive validity check in caminfo (#5553) * Removed preemptive validity check for polygon * Removed unused import * Updated changelog * Qview command line Fix (#5505) * Avoid double image load when opening cubes from cmdline in qview * Added changelog entry * Revert interval change * Change qt to qt-main * Update deps and pcl cmake * Add float.h * CsmSerialNumber.trn - typo and PVL compilant fix (#5561) * Fixed typo * PVL compliant * PR feedback changes * hrsc2isis support for level 3 images (#5560) * Remove label check for level3 * update changelog * fix test * addressed PR feedback * fixed grammar * Fixed gllssi2isis to support V1.1 data (#5570) * Removed a debug output statement inadvertently left in noseam.cpp. Addresses #5660. (#5661) * Bug fixes to address incorrect handling of RADIUS in the jigsaw GUI and in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses #5642. (#5643) * The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected. * In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on. * Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section. * Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution. * Updated kaguyasp2ascii to support newer (detached) data (#5568) * Modified to work with new (detached) data * Updated changelog * Allow data specification outside current directory * Speeds up FunctionalTestCamstatsDefaultParameters (#5647) * speed up camstats * add changelog * fixes photomet not accepting backplanes (#5658) * fixes photomet not accepting backplanes * fix changelog * Converted to gtests * Add input cube attributes * Convert dstripe to gtests (#5665) * Convert dstripe to gtests * add changelog * Fixed build error * trigger build * trigger build * Update docs --------- Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Sarah Sutton <[email protected]> Co-authored-by: Sarah Sutton <[email protected]> Co-authored-by: kledmundson <[email protected]> Co-authored-by: Adam Paquette <[email protected]> Co-authored-by: Austin Sanders <[email protected]> Co-authored-by: Shin-ya Murakami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ISIS version(s) affected: x.y.z
dev
Description
The following line was left in noseam.cpp following conversion to a callable app in PR #5600...
Line 35: std::cout << "***going to run 2nd noseam method\n";
How to reproduce
Possible Solution
Remove it (and I will).
Additional context
The text was updated successfully, but these errors were encountered: