Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted noproj and its tests #4384

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Converted noproj and its tests #4384

merged 7 commits into from
Jan 21, 2022

Conversation

kaitlyndlee
Copy link
Contributor

@kaitlyndlee kaitlyndlee commented Mar 31, 2021

Description

Refactored noproj to be callable and converted its tests from Makefile to GTests. Added image data to the LineScannerCube fixture and added an assertion method to only compare the keywords in a group.

Related Issue

A part of the testing sprint.

Motivation and Context

Removes 298 MB of data.

How Has This Been Tested?

Added tests pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs
Copy link
Contributor

A couple of noproj tests failed in Jenkins.

Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about removing the GUI helpers "kaitlyndlee on Mar 31, 2021" (see main.cpp line 27-32). These should not have been removed in the noproj.cpp. They are GUI elements, "gears", that only show up in GUI mode. They don't change the output results, they help the interactive user to set some options.

Evertyhing else looks good

@acpaquette
Copy link
Collaborator

@scsides This is ready for another review

@acpaquette acpaquette requested a review from scsides January 21, 2022 21:51
@scsides scsides merged commit ff3ee87 into DOI-USGS:dev Jan 21, 2022
@acpaquette acpaquette mentioned this pull request Feb 17, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants