-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted noproj and its tests #4384
Conversation
A couple of noproj tests failed in Jenkins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about removing the GUI helpers "kaitlyndlee on Mar 31, 2021" (see main.cpp line 27-32). These should not have been removed in the noproj.cpp. They are GUI elements, "gears", that only show up in GUI mode. They don't change the output results, they help the interactive user to set some options.
Evertyhing else looks good
@scsides This is ready for another review |
Description
Refactored noproj to be callable and converted its tests from Makefile to GTests. Added image data to the LineScannerCube fixture and added an assertion method to only compare the keywords in a group.
Related Issue
A part of the testing sprint.
Motivation and Context
Removes 298 MB of data.
How Has This Been Tested?
Added tests pass.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: