Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noproj Test Fixes #4808

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Noproj Test Fixes #4808

merged 2 commits into from
Feb 24, 2022

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Feb 17, 2022

Change match file creation to a temp file, fixing noproj tests

Description

Updates a file created in noproj that resulted in collision when running tests in parallel. This file is no created as a temporary file that adds random characters to the file. Thus, avoiding the collision with other noproj tests. This issue wasn't detected in the original noproj conversion PR (#4384) as the tests were run sequentially locally and likely passed by chance in Jenkins

Related Issue

N/A

Motivation and Context

Clean Jenkins

How Has This Been Tested?

This is a test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@acpaquette acpaquette requested a review from scsides February 17, 2022 16:24
isis/src/base/apps/noproj/noproj.cpp Outdated Show resolved Hide resolved
@acpaquette acpaquette merged commit 7fbd849 into DOI-USGS:dev Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants