Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review test timeouts #4213

Closed
jpaten opened this issue Oct 25, 2024 · 0 comments · Fixed by #4266
Closed

Review test timeouts #4213

jpaten opened this issue Oct 25, 2024 · 0 comments · Fixed by #4266
Assignees
@jpaten
Labels
canary Done by the Clever Canary team

Comments

@jpaten
Copy link
Contributor

jpaten commented Oct 25, 2024 •
edited
Loading

  • Review whether test and event timeouts are specified unnecessarily
  • Reduce code repetition in calling timeouts through test.beforeEach where necessary
  • Review Slack
@jpaten jpaten self-assigned this Oct 25, 2024
@github-actions github-actions bot added the canary Done by the Clever Canary team label Oct 25, 2024
@jpaten jpaten mentioned this issue Nov 8, 2024
Merged
jpaten added a commit that referenced this issue Nov 13, 2024
@jpaten
test: rationalized test timeouts (#4213)
a8194f5
jpaten added a commit that referenced this issue Nov 13, 2024
@jpaten
test: cleanup remaining timeouts (#4213)
1d0ecd4
@jpaten jpaten mentioned this issue Nov 13, 2024
Merged
@jpaten jpaten linked a pull request Nov 13, 2024 that will close this issue
test: rationalized test timeouts (#4213) #4266
Merged
jpaten added a commit that referenced this issue Nov 14, 2024
@jpaten
test: renamed timeout variables (#4213)
bc40b68
NoopDog pushed a commit that referenced this issue Nov 14, 2024
@jpaten
test: rationalized test timeouts (#4213) (#4266)
22db235
@NoopDog NoopDog mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpaten jpaten

Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: rationalized test timeouts (#4213) DataBiosphere/data-browser
1 participant
@jpaten