test: create tests for index export button (#4117)

[jpaten]

Ticket

Closes #4117.

Reviewers

@NoopDog .

Changes

• Added the following tests for the "index" export page:
• Workflow smoke test
  • Click the "Export" button
  • Click the "Request File Manifest" button
  • Select one checkbox from the File Format table and all possible Organism Type checkboxes
  • Click the "Prepare Manifest" button
  • Click the "Download Manifest" Button
  • Check that a file downloads
• Selected Data Summary test
  • Read the counts next to the Index Export Button (see screenshot)
  • Click the "Export" button
  • Check that the counts on the index page match the counts under "Selected Data Summary"

Questions

• Should we attempt to capture the download from the "Download Manifest" button, and if so, should we make any checks about it? Right now the download is made but we do not check the file name or size

[MillenniumFalconMechanic]

Really solid Jonah - thank you! Just a few nits and q's.

[MillenniumFalconMechanic]

This is an interesting one! I feel like it'd be slightly more readable if you handled the error case separately/explicitly rather than creating a dummy match array. I'd probably write it more like:

• Get the inner text, trim, match
• If the match is truthy, push the [1] value to the headers array
• Otherwise, push "ERROR" to the headers array

Thoughts?

[jpaten]

I refactored it so that it just fails the test if the regex doesn't match fully, let me know if that works! I think it's a little easier to read this way.

[MillenniumFalconMechanic]

Got it. I think the regex complexities should be resolved when we started adding test IDs.

[MillenniumFalconMechanic]

Do we need the nullish coalescing here now that requestLandingMessage is a required value? If it is still necessary, I feel it might make more sense to only execute the expect if there is a value for requestLandingMessage; that way, we will never be in a situation where we're calling page.getByText(""). Something like:

const requestLandingMessage = tab.indexExportPage.requestLandingMessage;
if ( requestLandingMessage ) {
  expect(...)
}

[jpaten]

Whoops, no we don't! Thanks for catching that, I'll fix it

[MillenniumFalconMechanic]

Got it. I think the regex complexities should be resolved when we started adding test IDs.

[jpaten]

@MillenniumFalconMechanic I addressed your one comment, and also updated the test timeouts, since I noticed it had failed once because the loading screen after clicking the request button was taking long enough that it timed out. I'll document this as part of #4213, but just wanted to let you know!

[MillenniumFalconMechanic]

LGTM, thanks Jonah!