Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dogfood recent changes #1827

Merged
merged 108 commits into from
May 10, 2024
Merged

Dogfood recent changes #1827

merged 108 commits into from
May 10, 2024

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented May 9, 2024 •
edited
Loading

What and why?

🐶 Dogfooding. Major elements:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

maciejburda and others added 30 commits March 20, 2024 15:34
@maciejburda
Merge pull request #1734 from DataDog/release/2.8.1
8e0a688 
Release 2.8.1
@maxep
RUM-2816 WebView Record Receiver
4174d09
@maxep
Update testUnsupportedView()-allowAll-privacy.png.json
1f5b758
@maxep
RUM-2816 Use corrected date
193975f
@maxep
RUM-2816 Apply rum view time offset
0242681
@maxep
Merge pull request #1720 from DataDog/maxep/RUM-2816/web-view-sr-rece…
e25a3bf 
…iver

RUM-2816 Session Replay Browser Record Receiver
@maxep
RUM-2813 Add webview replay configuration
819b4dd
@maxep @ncreated
Apply suggestions from code review
d511735 
Co-authored-by: Maciek Grzybowski <[email protected]>
@maxep
Apply suggestions from code review
92dc3b0
@maxep
Merge pull request #1754 from DataDog/maxep/RUM-2813/sr-webview-privacy
6c4d5d1 
RUM-2813 Add webview replay configuration
@maxep
RUM-3531 WebView slot cache
d524f2b
@maxep
RUM-3135 Build hidden webview wireframes
6eff630
@maxep
Merge pull request #1769 from DataDog/release/2.9.0
973fb6e 
Release 2.9.0
@maxep
RUM-3531 Use NSHashTable as webview cache
62185d6
@maxep
Merge pull request #1760 from DataDog/maxep/RUM-3531/hide-webview-wir…
d4b1d4a 
…eframe

RUM-3531 WebView slot cache
@maxep
Merge branch 'develop' into feature/webview-replay
cc5692d
@maxep
Fix feature scope conflict
aec536a
@maxep
Update CHANGELOG.md
0134202
@maxep
Merge branch 'develop' into feature/webview-replay
ec3006f
@ncreated
RUM-3470 Support head-based trace sampling for local traces and autom…
8a89706 
…atic distributed tracing
@maciejburda
Correct FPS for VisionOS
c478274
@maciejburda
Changes to support macOS logs
bd29f61
@maciejburda
Clean up
f13329c
@maciejburda
Fix compilation issue on ios
26385f1
@maciejburda
Run linter
d4d5c99
@maciejburda
PR fixes
f66af65
@maciejburda
Fix test
7562259
@maxep
RUM-4086 Synchronize SR info with webviews
6abffa1
@maciejburda
PR Fixes
b5a4a51
@maciejburda
Add smoke tests for macOS
687903b
ganeshnj and others added 20 commits May 7, 2024 18:34
@ganeshnj
Merge branch 'master' into develop
13b8b79 
# Conflicts:
#	DatadogCore/Tests/Datadog/TracerTests.swift
#	DatadogInternal/Sources/NetworkInstrumentation/Datadog/HTTPHeadersWriter.swift
@ganeshnj
chore: add badges for SPI and CP
a27befc
@ganeshnj
Merge pull request #1820 from DataDog/ganeshnj/chore/badges
440c890 
chore: add badges for SPI and CP
@ncreated
Merge pull request #1819 from DataDog/ganeshnj/chore/merge-master
1a2af32 
Merge 'master' into develop #1818
@maciejburda
RUM-3284 Add background activity when run from extension
d7fe1da
@maciejburda
RUM-3284 Provide process info background tasks for extensions
13ec282
@maciejburda
RUM-3284 Update CHANGELOG
23bc3df
@maciejburda @ncreated
Update DatadogCore/Sources/Core/Storage/Directories.swift
08ff6dd 
Co-authored-by: Maciek Grzybowski <[email protected]>
@maciejburda
RUM-3284 Fix after rebase
1c2c466
@maciejburda
RUM-3284 Clean up after rebase
a14f506
@maciejburda
Merge pull request #1803 from DataDog/maciey/RUM-3284-widget-crash-pr…
a0e9c69 
…evention

RUM-3284 Extension background upload
@maciejburda
Merge pull request #1815 from DataDog/nogorodnikov/rum-4418/add-missi…
56eba25 
…ng-addattribute-removeattribute-objc-api

RUM-4418: Add missing global `addAttribute`/`removeAttribute` Logs API in ObjC
@maciejburda
Merge pull request #1813 from DataDog/nogorodnikov/remove-unused-samp…
a3e27be 
…lerate-parameter-from-ddlogsconfiguration

Remove unused `sampleRate` parameter from `DDLogsConfiguration` object
@ganeshnj @maciejburda
Update CHANGELOG for 2.11.0 release
7445823
@ganeshnj @maciejburda
Bumped version to 2.11.0
dcee731
@maciejburda
Update CHANGELOG
e31ced7
@maciejburda
Update CHANGELOG
6a4e624
@maciejburda
Fix flaky test
f2f7dd9
@maciejburda
Merge pull request #1809 from DataDog/release/2.11.0
2e74021 
Merge `release/2.11.0` to `develop`
@maciejburda
Merge branch 'develop' into update-dogfooding
f5fcd39 
# Conflicts:
#	Datadog/Datadog.xcodeproj/project.pbxproj
#	dependency-manager-tests/spm/App/ViewController.swift
@maciejburda maciejburda marked this pull request as ready for review May 9, 2024 16:30
@maciejburda maciejburda requested review from a team as code owners May 9, 2024 16:30
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 9, 2024 •
edited
Loading

Datadog Report

Branch report: dogfooding-conflict-resolve
Commit report: f5fcd39
Test service: dd-sdk-ios

✅ 0 Failed, 3047 Passed, 0 Skipped, 4m 4.85s Total Time
❄️ 1 New Flaky
🔻 Test Sessions change in coverage: 10 decreased, 4 increased

New Flaky Tests (1)

  • testGivenDataStoredInAllFeatureDirectories_whenClearAllDataIsUsed_allFilesAreRemoved - DatadogTests - Last Failure

    Expand for error 
     Assertion Failure at DatadogTests.swift:343: XCTAssertEqual failed: ("3") is not equal to ("4") - Each feature stores 2 files - one authorised and one unauthorised

🔻 Code Coverage Decreases vs Default Branch (10)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests iOS 44.97% (-0.35%) - Details
  • test DatadogLogsTests tvOS 45.03% (-0.34%) - Details
  • test DatadogCrashReportingTests tvOS 27.68% (-0.23%) - Details
  • test DatadogCrashReportingTests iOS 27.66% (-0.23%) - Details
  • test SRSnapshotTests 33.25% (-0.22%) - Details

@maciejburda maciejburda merged commit 3aa7242 into dogfooding May 10, 2024
18 checks passed
@maciejburda maciejburda deleted the dogfooding-conflict-resolve branch May 10, 2024 10:19
@maciejburda maciejburda mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maciejburda @NachoSoto @ncreated @hestonhoffman @maxep @0xnm @ganeshnj