Dogfood recent changes #1839
Merged
Dogfood recent changes #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a cross platform attribute `_dd.error.include_binary_images` that will attach binary images to error reports by creating a backtrace and pulling the binary images from it. It contains a TODO to replace backtrace generation with a different method of binary image attachment at a future time.
Use a separate BinaryImage structure for encoding in Logs. Send BinaryImages through feature baggage instead of re-fetching when Logs trigger a RUM error.
fix: Remove `WKWebView` instance in tests
fix: Remove flaky assertion due to upload at init
fix: WebView leak in test
ganeshnj
approved these changes
May 16, 2024
feat: Support adding binary images to non-crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
WKWebViewinstance in tests #1838Review checklist
Custom CI job configuration (optional)
tools/