Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove flaky assertion due to upload at init #1840

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

maxep
Copy link
Member

@maxep maxep commented May 15, 2024

What and why?

The upload at init could pick files in the authorized folder, so we cannot guarantee that the files will be there while running the test.

The assertion can be removed as we only need to assert that the clearAllData removes all files.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners May 15, 2024 16:00
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Mentioning #1798 for GH link reference.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 15, 2024

Datadog Report

Branch report: maxep/fix-flakiness
Commit report: c158008
Test service: dd-sdk-ios

✅ 0 Failed, 2843 Passed, 0 Skipped, 2m 22.54s Total Time
🔻 Test Sessions change in coverage: 9 decreased, 3 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (9)

This report shows up to 5 code coverage decreases.

  • test DatadogCoreTests tvOS 78.81% (-0.81%) - Details
  • test DatadogLogsTests tvOS 45.06% (-0.32%) - Details
  • test DatadogLogsTests iOS 45% (-0.32%) - Details
  • test DatadogCoreTests iOS 73.27% (-0.22%) - Details
  • test DatadogRUMTests tvOS 80.81% (-0.22%) - Details

@maxep maxep merged commit 3603a61 into develop May 16, 2024
6 checks passed
@maxep maxep deleted the maxep/fix-flakiness branch May 16, 2024 09:36
@maciejburda maciejburda mentioned this pull request May 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants