Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom tags #15

Closed
wants to merge 3 commits into from
Closed

Add custom tags #15

wants to merge 3 commits into from

Conversation

helmus
Copy link
Contributor

@helmus helmus commented Jul 6, 2018

This is the same pr as #13
Fixes failing tests because of race condition in the bash script, bumps uwsgi to the latest version, build tests from source instead from github

@Tenzer Tenzer mentioned this pull request Sep 5, 2018
@kitsuyui
Copy link

kitsuyui commented Aug 1, 2019

@DataDog
Any update on this?
I want to use this feature too.

@remeh
Copy link
Contributor

remeh commented Nov 6, 2019

Hello @helmus
Thanks for your contribution and sorry for the very late reply.
I've merged #17 which contains custom tags support on top of various other additions. Unfortunately, it won't use the same field name for the configuration, I hope it won't be a problem for you if you switch to use the master branch of uwsgi-dogstatsd. The field name in master is: dogstatsd-extra-tags and tags are comma-separated.
However, I've cherry-picked your commit (to have you as an author of a contribution in the git log) about the tests fix + uwsgi upgrade 👍
Once again, thank you.

@remeh remeh closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants