Align with stock statsd plugin, add extra tags, add metric whitelisting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickwilliams-eventbrite
force-pushed
the
filters-and-tags
branch
from
306c045 to
9d16f1f
Compare
- After this plugin was created, the stock statsd plugin in the uWSGI repo was updated to support disabling worker metrics and forcing all metrics to be gauges. The first change this commit makes is to port those two changes into this plugin. - We only use 3-4 metrics of the dozens that uWSGI records. I've added a whitelisting feature that enables us to filter out undesired metrics, reducing our use of Datadog custom metrics. - We need the ability to specify additional tags, so that we can more easily graph uWSGI metrics belonging to specific applications (or group uWSGI metrics by application). I've added that capability here. This change is completely backwards compatible. If a user has a config such as the following, the plugin behavior will continue in the exact same manner as before this change: ``` stats-push=dogstatsd:localhost:8135,uwsgi ``` Now, however, we can add more advanced configuration options, like below, to alter the plugin behavior: ``` stats-push=dogstatsd:localhost:8135,uwsgi dogstatsd-extra-tags=app:foo_service dogstatsd-no-workers=true dogstatsd-whitelist-metric=core.busy_workers dogstatsd-whitelist-metric=core.idle_workers dogstatsd-whitelist-metric=core.overloaded dogstatsd-whitelist-metric=socket.listen_queue ```
nickwilliams-eventbrite
force-pushed
the
filters-and-tags
branch
from
9d16f1f to
bc56a1b
Compare
|
Bump :-) |
|
Almost 3 months have gone by... any feedback? |
|
We have started using your fork as well. Haven't had any issues. 🎉 |
remeh
reviewed
Oct 30, 2019
There was a problem hiding this comment.
Hey @nickwilliams-eventbrite
Sorry for the late reply. First, thanks for your contribution 🙇
I had the chance to review and test your PR and it works well! I've caught a small typo in the doc of one of the new field you've added, could I ask you to fix it before we proceed to merge your PR? Thank you!
| stats-push = dogstatsd:127.0.0.1:8125,myapp | ||
| dogstatsd-extra-tags = app:foo_service,instance:1 | ||
| dogstatsd-no-workers = true | ||
| dogstatsd-all_gauges = true |
There was a problem hiding this comment.
I think it should be dogstatsd-all-gauges here.
|
Hello @nickwilliams-eventbrite |
This was referenced Nov 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is completely backwards compatible. If a user has a config such as the following, the plugin behavior will continue in the exact same manner as before this change:
Now, however, we can add more advanced configuration options, like below, to alter the plugin behavior: