Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add home page #155

Closed
Dun-sin opened this issue Sep 23, 2022 · 39 comments
Closed

[FEATURE] add home page #155

Dun-sin opened this issue Sep 23, 2022 · 39 comments
Assignees
@Dun-sin
Labels
assigned Issue is no longer available for anyone else to work on EddieHub:good-first-issue feature good first issue Good for newcomers released

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 23, 2022

Description

👇🏽This is the design for the home page, since we have none.

The white part should be a video of how to use the website, example will be the gif in the Readme

Screenshots

191252524-20d59a17-62cf-4895-a1ad-04db3b47f8f2
@Dun-sin Dun-sin added good first issue Good for newcomers feature EddieHub:good-first-issue up for grabs Issue is still available for anyone to work on labels Sep 23, 2022
@Dun-sin Dun-sin mentioned this issue Sep 23, 2022
Closed
@ctoffanin
Copy link
Contributor

ctoffanin commented Sep 24, 2022 •
edited
Loading

Hi Dunsin, can I be assigned to this? I'll wait till hacktoberfest starts.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 24, 2022 •
edited
Loading

You can do it now, but I will merge it when Hacktoberfest starts🙌🏽 it's the merge that counts

@Vishrut19
Copy link

Hey @ctoffanin can I help you with this contribution ?

@ctoffanin
Copy link
Contributor

If @Dun-sin is ok with it, it can be assigned to you. I don't mind.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 26, 2022

sure @Vishrut19

@Dun-sin Dun-sin assigned Vishrut19 and unassigned ctoffanin Sep 26, 2022
@Vishrut19
Copy link

Hey @Dun-sin I was trying to work on this task that is assigned to me but I am a bit confused as what has to be done in this issue ? Can you please elaborate a bit about it to me

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 27, 2022

image

When you open the website, it shows nothing but the side menu
Use the design above to add text and a quick video recording of the website

@Vishrut19
Copy link

okay got it @Dun-sin I will do it and yes Just wanted to ask you that is there a video recording available with you for reference.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 28, 2022

Nope, you can make yours or use the gif in the Readme file

@dhrumishah
Copy link
Contributor

Can I also help in this contribution? @Vishrut19 , @Dun-sin, @ctoffanin

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 29, 2022

Can I also help in this contribution? @Vishrut19 , @Dun-sin, @ctoffanin

depends on if @Vishrut19 needs help

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Sep 29, 2022
@dhrumishah
Copy link
Contributor

@Vishrut19 please let me know if you need help :)

@Vishrut19
Copy link

Vishrut19 commented Sep 29, 2022 •
edited
Loading

Yes you can help me as you seem to be experienced in this i.e. Open Source Contribution thing @dhrumishah

@dhrumishah
Copy link
Contributor

Not much but yes I have contributed. Can you let me know how can I help? @Vishrut19

@Vishrut19
Copy link

Can we plan a time and connect on discord for the same (if you are from india)? @dhrumishah

@dhrumishah
Copy link
Contributor

dhrumishah commented Sep 29, 2022 •
edited
Loading

Yeah sure :)

Here's my ID: Dhrumi | 0xdee#0946 @Vishrut19

@Vishrut19
Copy link

Hey @Dun-sin I am done with the text thing. Can you please see if it is okay ?
Text

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

@Vishrut19 looks good

@Vishrut19
Copy link

Vishrut19 commented Sep 30, 2022 •
edited
Loading

Okay so tomorrow can you merge my PR ? @Dun-sin

@Vishrut19
Copy link

Hey @Dun-sin I am done with adding gif to the page. I am attaching the picture please have a look at it and let me know if it is okay then we can move forward.
Screenshot 2022-09-30 at 7 47 14 PM

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

Nice, maybe a border would be nice to differentiate the video from the original background

@Vishrut19
Copy link

Hey @Dun-sin please have a look at it I have tried doing something.
Screenshot 2022-09-30 at 8 23 48 PM

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022 •
edited
Loading

Hey @Dun-sin please have a look at it I have tried doing something.
Screenshot 2022-09-30 at 8 23 48 PM

Good, but the space in between the video and the text doesn't look good, I think it's too much

@Vishrut19
Copy link

Now @Dun-sin ! Sorry for disturbing you again and again since it is my first time thats why.
Screenshot 2022-09-30 at 8 29 32 PM

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

Now @Dun-sin ! Sorry for disturbing you again and again since it is my first time thats why.
Screenshot 2022-09-30 at 8 29 32 PM

No worries, it's okay now

@Vishrut19
Copy link

Thanks a lot @Dun-sin then is it mergable now ? If that is the correct word 😂

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

Thanks a lot @Dun-sin then is it mergable now ? If that is the correct word 😂

Well you have to create a pull request

@Vishrut19
Copy link

Vishrut19 commented Sep 30, 2022 •
edited
Loading

okay but tomorrow right ? @Dun-sin or today only?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

okay but tomorrow right ? @Dun-sin or today only?

Your choice, it's my merge that matters

@Vishrut19
Copy link

okay so you will merge tomorrow ? @Dun-sin

@Srinika99
Copy link

Description

👇🏽This is the design for the home page, since we have none.

The white part should be a video of how to use the website, example will be the gif in the Readme

Screenshots

191252524-20d59a17-62cf-4895-a1ad-04db3b47f8f2

hi, i wanted to ask apart from the description of landing page you mentioned, if one can work on generating a different , interactive landing page?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Sep 30, 2022

Description

👇🏽This is the design for the home page, since we have none.

The white part should be a video of how to use the website, example will be the gif in the Readme

Screenshots

191252524-20d59a17-62cf-4895-a1ad-04db3b47f8f2

hi, i wanted to ask apart from the description of landing page you mentioned, if one can work on generating a different , interactive landing page?

You can create it as a separate issue

This was referenced Sep 30, 2022
Closed
Closed
Closed
Closed
Closed
@Srinika99 Srinika99 mentioned this issue Oct 1, 2022
Closed
@Dun-sin Dun-sin added up for grabs Issue is still available for anyone to work on and removed assigned Issue is no longer available for anyone else to work on labels Oct 8, 2022
@Dun-sin Dun-sin assigned Dun-sin and unassigned Vishrut19 Oct 8, 2022
@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Oct 8, 2022
@Dun-sin Dun-sin closed this as completed in 6ca1e15 Oct 9, 2022
Dun-sin added a commit that referenced this issue Oct 9, 2022
@Dun-sin
feat: add homepage to not be seen when a generator is clicked
d24a654 
closes #155
@Dun-sin
Copy link
Owner Author

Dun-sin commented Oct 9, 2022

🎉 This issue has been resolved in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dun-sin Dun-sin

Labels
assigned Issue is no longer available for anyone else to work on EddieHub:good-first-issue feature good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
5 participants
@ctoffanin @Vishrut19 @Dun-sin @dhrumishah @Srinika99