Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added GIF and Text in HomePage #191

Closed
wants to merge 4 commits into from
Closed

feat: Added GIF and Text in HomePage #191

wants to merge 4 commits into from

Conversation

Vishrut19
Copy link

@Vishrut19 Vishrut19 commented Oct 1, 2022

πŸ› οΈ Fixes #155

πŸ‘¨β€πŸ’» Changes proposed

  • Added Text in the HomePage.
  • Added GIF in the HomePage.
  • Also Made the Video Responsive.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Screenshot 2022-09-30 at 8 29 32 PM

@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
code-magic βœ… Ready (Inspect) Visit Preview Oct 1, 2022 at 10:50AM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project by submitting a pull request

Make sure you filled the template properly and followed the rules in Contributing.md file, Thank you! Welcome to the community πŸ€“

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2022

Stop using resolved😭 use closes #issue or fixes #issue

@Vishrut19
Copy link
Author

So now again I have to raise PR ?

@Vishrut19 Vishrut19 closed this Oct 1, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2022

So now again I have to raise PR ?

no, you can edit

@Vishrut19 Vishrut19 reopened this Oct 1, 2022
@Vishrut19
Copy link
Author

I have edited it @Dun-sin

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2022

Also, found some problems

  • It isn't aligned
  • the texts of Just one click and generate gradient are too small and far apart
    image

@Vishrut19
Copy link
Author

Yes But I sent you the same pic yesterday then you said it was fine ! So I kept it as it was

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2022

On mobile, it covers the menu
image

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 1, 2022

Yes But I sent you the same pic yesterday then you said it was fine ! So I kept it as it was

On your screen, it was fine, on mine it's not

on a different viewport, it looks like this
image

It has to look good on viewports, it's not all about just adding texts, you have to check how they look on different devices

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 3, 2022

@Vishrut19 any update on this? If you can't work it out let me know

@mchirag2002
Copy link

hey @Dun-sin can i take up this issue if @Vishrut19 is not going to??

@Dun-sin Dun-sin closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add home page
3 participants