[FEATURE-13]: support relators role notes as part of creators text #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorpa
commented
Sep 22, 2022
davorpa
commented
Sep 22, 2022
18 tasks
eshellman
reviewed
Sep 24, 2022
e.g. for creators of type translator: `trl.:` ABC
|
Force-push (#13 (comment)) rebase was for integrate #8 functions |
|
Suppose someone enters |
This comment was marked as outdated.
This comment was marked as outdated.
|
My point is that verifying validity of a relator token is easy. |
Then, I will also put a list like |
This flag validates the relator term and it position inside each creator string
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
Add feature(s)
Description
Recently we introduced the
ABBR.:note in markdown sources to support relator abbreviations attached to each creator.e.g. for creators of type translator:
More relators terms: https://loc.gov/marc/relators/relaterm.html
This PR adds supports to them
Context
I attach two files in a zip: fpb-parser-data.zip. Compares them to test differences. It seems all right