Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(books): free-programming-books-zh broken links #6986

Merged
merged 7 commits into from
Aug 9, 2022

Conversation

LuigiImVector
Copy link
Member

What does this PR do?

Remove resource(s) | Improve repo

For resources

Description

Solved a problem of #6942.

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@LuigiImVector LuigiImVector self-assigned this Aug 5, 2022
@LuigiImVector LuigiImVector added 👀 Needs Review Is this really a good resource? Reviews requested. 🗣️ locale:zh Resources addressing "Chinese" language labels Aug 5, 2022
@davorpa
Copy link
Member

davorpa commented Aug 5, 2022

Is a translation of a leanpub book https://leanpub.com/learnvimscriptthehardway. Needs review about access rights too (see issue #6852 about)?

@LuigiImVector
Copy link
Member Author

Is a translation of a leanpub book https://leanpub.com/learnvimscriptthehardway. Needs review about access rights too (see issue #6852 about)?

The official website for that book is: https://learnvimscriptthehardway.stevelosh.com/, it's just a translation of this website so I think it's okay

@LuigiImVector LuigiImVector requested a review from davorpa August 6, 2022 12:47
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enough for me

@eshellman eshellman merged commit 6f39e80 into EbookFoundation:main Aug 9, 2022
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Needs Review Is this really a good resource? Reviews requested. 🗣️ locale:zh Resources addressing "Chinese" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants