Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove non-free leanpub books #7026

Merged
merged 3 commits into from
Aug 25, 2022
Merged

remove non-free leanpub books #7026

merged 3 commits into from
Aug 25, 2022

Conversation

eshellman
Copy link
Collaborator

@eshellman eshellman commented Aug 18, 2022 •
edited
Loading

45 40 books removed, the 59 64 leanpub books remaining are still free.

Addresses #6852

Remaining books either have free-to-read html, or they have price set to $0

@eshellman
remove non-free leanpub books
1ed78be 
45 books removed, the 59 books remaining are still free.
@davorpa davorpa added 🗣️ locale:en Resources addressing "English" language 🗣️ locale:es Resources addressing "Spanish / español" language 🗣️ locale:pt Resources addressing "Portuguese / Brazilian" language 🗣️ locale:ru Resources addressing "Russian / Русский язык" language 🗣️ locale:id Resources addressing "Indonesian" language 🗣️ locale:tr Resources addressing "Turkish / Türkçe" language labels Aug 19, 2022
@davorpa davorpa self-requested a review August 19, 2022 07:37
@davorpa davorpa linked an issue Aug 19, 2022 that may be closed by this pull request
Many Leanpub books no longer free #6852
Closed
@davorpa davorpa added the question Needs clarification by involved users / reviewers label Aug 19, 2022
davorpa
davorpa reviewed Aug 20, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are some with 0$ that need membership after added to cart. E.g.:

  • free-programming-books-es.md 
    * [JavaScript, ¡Inspírate!](https://leanpub.com/javascript-inspirate) (Leanpub cuenta requerida)

Could you review again in all files?

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Aug 20, 2022
@davorpa davorpa added 👥 discussion This Repo is guided by its community! Let's talk! help wanted Needs help solving a blocked / stucked item labels Aug 22, 2022
@eshellman
re-add 5, fix 3
97822ce 
a programmed scan of the leanpub urls reveal 5 that should not have been removed and 3 that should use /read urls
@eshellman eshellman removed the help wanted Needs help solving a blocked / stucked item label Aug 22, 2022
@eshellman eshellman requested a review from davorpa August 23, 2022 13:33
@davorpa davorpa removed the 👥 discussion This Repo is guided by its community! Let's talk! label Aug 24, 2022
davorpa
davorpa approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's right to my oldy glassed eyes 🤣

@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed question Needs clarification by involved users / reviewers waiting for changes PR has been reviewed and changes/suggestions requested labels Aug 24, 2022
@eshellman eshellman merged commit 19a03ae into main Aug 25, 2022
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Aug 25, 2022
@davorpa
Merge EbookFoundation#7026 into maintenance/homogenize-in-process-not…
4f31e96 
…es to solve conflicts

Cherry pick until ce57ea3 + 19a03ae
@davorpa davorpa mentioned this pull request Aug 25, 2022
Merged
5 tasks
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Aug 27, 2022
@davorpa
Merge EbookFoundation#7026 into maintenance/shell-scripting-section t…
b835cb4 
…o solve conflicts

- `books/free-programming-books-langs.md`: It preserves Leanpub's readable Powershell resources as is but moving them to `Shell scripting` category
- `books/*`: merge was clean without conflicts

Cherry pick until commit 19a03ae
@eshellman eshellman deleted the remove-leanpub-subscription-books branch October 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorpa davorpa davorpa approved these changes

Assignees

@eshellman eshellman

Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:en Resources addressing "English" language 🗣️ locale:es Resources addressing "Spanish / español" language 🗣️ locale:id Resources addressing "Indonesian" language 🗣️ locale:pt Resources addressing "Portuguese / Brazilian" language 🗣️ locale:ru Resources addressing "Russian / Русский язык" language 🗣️ locale:tr Resources addressing "Turkish / Türkçe" language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many Leanpub books no longer free
2 participants
@eshellman @davorpa