Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

69 create systems comps #102

Merged
merged 21 commits into from
Nov 10, 2023
Merged

69 create systems comps #102

merged 21 commits into from
Nov 10, 2023

Conversation

TSKsmiley
Copy link
Contributor

@TSKsmiley TSKsmiley commented Nov 9, 2023

Closes #69
Closes #58
Closes #59

Changes/Additions:

  • Project Item
  • Project item navbar
  • Project item menu
  • Testing for it

@TSKsmiley TSKsmiley linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for ecdar ready!

Name Link
🔨 Latest commit a12df4f
🔍 Latest deploy log https://app.netlify.com/sites/ecdar/deploys/654e1b34f7f256000853ea01
😎 Deploy Preview https://deploy-preview-102--ecdar.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TSKsmiley and others added 5 commits November 9, 2023 11:23
* Implemented everything

I made a huge mistake and merge comitted the branch linked to issue #50 into my original CSS branch. This included every individual commits from the other branch into my CSS branch. I tried to revert it but failed and was therefore forced to use this solution.

* Added dark mode color to edges

* Created a CSS variable support check

This makes sure that no unsupported CSS variables are used. The supported CSS variables are specified  in CSSVariables.ts

* Changed resizer size

* Removed unnecessary media schemes

* Removed mediaFeature check

* Corrrect the parsed error type

* Removed the passing of the global window variable

* Removed the need for range checking by using zod

* Improved the zod schemes

The zod schemes now enforce:
- The color value range
- That the "default" mediascheme contains a specification of all specified CSS variables

and more...

* Fix typo

* Did some color styling to the navbar
@TSKsmiley TSKsmiley marked this pull request as ready for review November 9, 2023 13:07
@NybyDK NybyDK linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link
Contributor

@DenFlyvendeGed DenFlyvendeGed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Jesper276 Jesper276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NybyDK NybyDK merged commit df1616e into main Nov 10, 2023
6 checks passed
@NybyDK NybyDK deleted the 69-create-systems-comps branch November 10, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants