enable lints from workspace for puffin_http #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
clippy warning: docs for function returning `Result` missing `# Errors` section help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
warning: `to_string()` called on a `&str` help: consider using `.to_owned()` help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#str_to_string note: requested on the command line with `-W clippy::str-to-string`
warning: unnecessary structure name repetition help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self note: requested on the command line with `-W clippy::use-self`
as is the function `run` of a thread, passing by ref seems to have no interest.
clippy warning: non-binding `let` without a type annotation help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
TODO: allow user code to handle error ?
for write `PROTOCOLE_VERSION` in packet to be send to client(s).
- ignore unwrap_used as it's an example. - ignore print_stderr as it's an example. - add a `;` to the last statement for consistent formatting help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
PR #237 would have to be integrated before. It fixes the CI task |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Enable lints from workspace for
puffin_httpand fix the report from lints.Related Issues
No related issue.