Small optim of frame serialization for puffin_http #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frame_view var is only added for use scope_collection member. This change to directly use a ScopeCollection.
replace linked parameter scope_collection + bool send_all_scopes with an Option<ScopeCollection>
It's not nessessary to use the toolchain specified for puffin. And `cargo-vet` failed to build with 1.76 toolchain.
this is useless as already done by serde serialization. BREAKING CHANGE: the frame serialization format change. Introducing PFD5
This allow to serialize scopes collection directly, without need to collect scope in a temporary Vec.
instead of serialize in a temporary Vec<u8> before coping data in writer after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it include some change from PR #237 & #238, merge it first.
Checklist
Description of Changes
Optimization of the write of frame data before send to client with puffin_http.
Example :
Stats:
When tested with my test/example app puffin-test-app with 250 loops (who only do a sleep), I got this :
Note :
Mean self timeis forPuffinServerImpl::sendRelated Issues
No listed issue.