[HOLD for payment 2025-01-15] [Awaiting payment] Chat - App crashes when right clicking on message (open context menu)

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.81-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

1.Go to staging.new.expensify.com
2.Go to any report.
3.Send a message.
4. Right click on the message.

Expected Result:

App will not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6707495_1736190717242.20250107_022342.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes.

What is the root cause of that problem?

It comes from #54710. We use the EducationalTooltip in MenuItem and it crashes here because the context menu isn't inside the Navigation container.

App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx

Line 20 in fa59257

const navigation = useNavigation();

What changes do you think we should make in order to solve the problem?

For this case, we should get the navigation from NavigationContext and return early if it's undefined here

const navigation = useContext(NavigationContext);
if (!navigation) {
    return () => {};
}

App/src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx

Line 45 in fa59257

useEffect(() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MonilBhavsar]

Returning empty does not work, right? Because tooltip is supposed to wrapped around the children component

[MonilBhavsar]

cc @rayane-djouah @ishpaul777 too

[ishpaul777]

@rayane-djouah is working on a fix #54832

[rayane-djouah]

PR: #54832

[mkzie2]

Returning empty does not work, right? Because tooltip is supposed to wrapped around the children component

@MonilBhavsar No, I mean return early in the useEffect

[lanitochka17]

The Issue also reproducible when right click on the chat in LHN

Crash.2.mp4

[MonilBhavsar]

Issue was fixed
Thanks for handling this as a regression @rayane-djouah @ishpaul777 🙏

Screen.Recording.2025-01-06.at.4.34.38.PM.mov

[MonilBhavsar]

@isabelastisser I think we should pay @mkzie2 $100 for figuring out the regression and potential fix

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix crash when opening context menu #54832

If no regressions arise, payment will be issued on 2025-01-15. 🎊

[melvin-bot]

@MonilBhavsar @isabelastisser @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mkzie2]

@isabelastisser I think we should pay @mkzie2 $100 for figuring out the regression and potential fix

@MonilBhavsar Based on this, please help to assign me here for payment.

[ishpaul777]

please assign me and @rayane-djouah for PR, even though no Payment to be due to us 🙇