Feat: Make it possible to click the element the product training tooltip is pointing to #54710

rayane-djouah · 2025-01-01T11:36:49Z

Explanation of Change

Fixed Issues

$ #54068
$ #54701
PROPOSAL: #54068 (comment)

Tests

Sign in with a new account and complete the onboarding flow.

Concierge Chat Tooltip

On a small screen, verify the "Get started!" tooltip appears on the Concierge chat.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the Concierge chat.
Verify the tooltip does not show again.

FAB (Floating Action Button) Tooltip

Verify the tooltip on the FAB button appears.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the FAB.
Verify the tooltip does not show again.

QAB (Quick Action Button) Tooltip

Click on the FAB.
Verify a tooltip is displayed for the QAB.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the QAB.
Verify the tooltip does not show again.

Workspace Chat Tooltip

Create a workspace if one does not already exist.
Verify that when you have your workspace chat in the LHN (Left Hand Navigation), a tooltip on the workspace chat shows.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Open the workspace chat.
Verify the tooltip does not show again.

Filter Button Tooltip

Click on the Search bottom tab.
Verify the tooltip on the Filter button shows up.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the Filter button.
Verify the tooltip does not show again.

Inbox Icon Tooltip

Verify a tooltip on the Inbox icon in the bottom tab shows up.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the Inbox.
Verify the tooltip does not show again.

Saved search tooltip

On a small screen, search for anything and click on save.
Verify that a tooltip is displayed on the three dots icon for the saved search list item
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the the three dots icon for the saved search list item.
Verify the tooltip does not show again.

"+" Button Tooltip in Invited Workspace

As another user, create a workspace and invite this user to the workspace.
As this user, navigate to the invited workspace chat.
Verify a tooltip on the "+" button is shown.
Verify you can interact with other elements on the screen without dismissing the tooltip.
Verify that when a modal is opened, the tooltip is hidden, and when the modal is closed, the tooltip reappears.
Click on the "+" button.
Verify the tooltip does not show again.

For all tooltips:

You should be able to interact with any element on the screen. The presence of a tooltip should not restrict interactions.
You should be able to click the element the tooltip is pointing to.
The tooltip should remain visible until you click the element it is pointing to. Interacting with other elements should not dismiss the tooltip except for modals.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-06.at.1.04.25.PM.mov

Screen.Recording.2025-01-06.at.1.00.45.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-04.at.10.50.30.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-04.at.22.46.57.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-04.at.22.49.34.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-02.at.5.59.49.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-04.at.10.44.40.PM.mov

… pointing to

…oduct-training-tooltip-is-pointing-to-2

…oduct-training-tooltip-is-pointing-to-pr

rayane-djouah · 2025-01-02T17:06:47Z

Screen.Recording.2025-01-02.at.5.59.49.PM.mov

melvin-bot · 2025-01-02T17:08:07Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-01-02T17:57:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-06.at.4.47.14.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-04.at.12.33.04.AM.mov

iOS: Native

Screen.Recording.2025-01-06.at.4.32.32.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-04.at.12.07.49.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-03.at.12.29.28.AM.mov

Screen.Recording.2025-01-04.at.12.24.14.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-06.at.5.12.06.PM.mov

ishpaul777 · 2025-01-02T19:42:09Z

Bug on filter tooltip, position feels tooo low (may not related) and also it does not disapper when clicking on it

Screen.Recording.2025-01-03.at.1.10.27.AM.mov

rayane-djouah · 2025-01-02T20:15:27Z

Bug on filter tooltip, position feels tooo low (may not related) and also it does not disapper when clicking on it

Hmm, It seems that the concierge tooltip (unrelated to the filter button tooltip) does not disappear when navigating away for the first time but it disappears when navigating away for the second time:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-02.at.21.12.09.mp4

I need to look into this.

ishpaul777 · 2025-01-02T20:21:13Z

filter button toopltip not visible on small screen

Screen.Recording.2025-01-03.at.1.50.02.AM.mov

ishpaul777 · 2025-01-02T20:45:36Z

Hmm, It seems that the concierge tooltip (unrelated to the filter button tooltip) does not disappear when navigating away for the first time but it disappears when navigating away for the second time:

same with the other workspace chat tooltip on same page on small screen

src/hooks/useBottomTabIsFocused.ts

rayane-djouah · 2025-01-03T16:00:33Z

Fixed hiding the tooltip for "rename saved search" tooltip here: 06f1b75

…ent-the-product-training-tooltip-is-pointing-to-pr

rayane-djouah · 2025-01-05T23:00:45Z

Updated

src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx

…earch page

rayane-djouah · 2025-01-06T09:30:21Z

Updated

ishpaul777

lgtm! All yours @puneetlath

puneetlath · 2025-01-06T15:27:19Z

src/components/FloatingActionButton.tsx

@@ -69,9 +70,11 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo
    const isNarrowScreenOnWeb = shouldUseNarrowLayout && platform === CONST.PLATFORM.WEB;
    const isFocused = useBottomTabIsFocused();
    const [isSidebarLoaded] = useOnyx(ONYXKEYS.IS_SIDEBAR_LOADED, {initialValue: false});
+    const isActiveRouteHome = useIsCurrentRouteHome();


NAB, but could we use the same terminology here? Either active route or current route.

Suggested change

const isActiveRouteHome = useIsCurrentRouteHome();

const isActiveRouteHome = useIsCurrentRouteHome();

melvin-bot · 2025-01-06T15:33:04Z

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

puneetlath · 2025-01-06T15:33:33Z

I left one NAB and merged with the lint check failing because this PR is already very large and we don't want to add more changes. We can handle those in follow-up. Thanks for the good work y'all!

OSBotify · 2025-01-06T15:41:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-06T18:34:37Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2025-01-07T10:48:27Z

@rayane-djouah This PR is failing with #54841, #54867

https://platform.applause.com/services/links/v1/external/97b2ba863b700fd7acddb8c149f5c7bb514df3e426d51ba086e817df5c2fd360

rayane-djouah added 12 commits December 17, 2024 15:41

Make it possible to click the element the product training tooltip is…

6174a6d

… pointing to

use isScreenFocused

ed54b83

Merge branch 'main' into Make-it-possible-to-click-the-element-the-pr…

2d2e16d

…oduct-training-tooltip-is-pointing-to-2

fix bug

0d49f67

fix bug

fe4bcb6

remove shouldHideEducationalTooltip

8de62b1

QAB hideProductTrainingTooltip

4c13d72

QAB hideProductTrainingTooltip

9d578d3

remove console log

629c8c2

Merge branch 'main' into Make-it-possible-to-click-the-element-the-pr…

5e5b74b

…oduct-training-tooltip-is-pointing-to-pr

Merge branch 'main' into Make-it-possible-to-click-the-element-the-pr…

57811e3

…oduct-training-tooltip-is-pointing-to-pr

fix errors

c8dc967

rayane-djouah marked this pull request as ready for review January 2, 2025 17:08

rayane-djouah requested a review from a team as a code owner January 2, 2025 17:08

melvin-bot bot requested review from ishpaul777 and removed request for a team January 2, 2025 17:08

correct copy usage

b7d5186

ishpaul777 mentioned this pull request Jan 2, 2025

PR - Tooltip - The educational tooltip for a new account is wrong #54701

Open

8 tasks

ishpaul777 reviewed Jan 2, 2025

View reviewed changes

src/hooks/useBottomTabIsFocused.ts Outdated Show resolved Hide resolved

rayane-djouah added 2 commits January 3, 2025 16:39

Refactor

2042262

hideProductTrainingTooltip for RENAME_SAVED_SEARCH tooltip

06f1b75

revert a change

4b2a934

rayane-djouah requested a review from ishpaul777 January 4, 2025 21:36

rayane-djouah added 4 commits January 4, 2025 22:39

add comment

aa2b173

Fix bug

473cad5

Fix QAB tooltip does not hide immediately

b4187ee

Merge branch 'Expensify:main' into Make-it-possible-to-click-the-elem…

d11826c

…ent-the-product-training-tooltip-is-pointing-to-pr

ishpaul777 reviewed Jan 6, 2025

View reviewed changes

src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx Outdated Show resolved Hide resolved

Fix: bottomtab tooltips (inbox and FAB) only hides on navigation to s…

1a52149

…earch page

rayane-djouah requested a review from ishpaul777 January 6, 2025 09:19

move prop to most relevant type

ed68330

Fix: clicking on admin chat dismiss the workspacechat tooltip

270a302

ishpaul777 approved these changes Jan 6, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath January 6, 2025 11:49

puneetlath approved these changes Jan 6, 2025

View reviewed changes

puneetlath merged commit 553c410 into Expensify:main Jan 6, 2025
17 of 18 checks passed

melvin-bot bot added the Emergency label Jan 6, 2025

puneetlath removed the Emergency label Jan 6, 2025

github-actions bot mentioned this pull request Jan 6, 2025

Deploy Checklist: New Expensify 2025-01-06 #54825

Open

58 tasks

rayane-djouah deleted the Make-it-possible-to-click-the-element-the-product-training-tooltip-is-pointing-to-pr branch January 6, 2025 18:48

mkzie2 mentioned this pull request Jan 6, 2025

Chat - App crashes when right clicking on message (open context menu) #54827

Open

8 tasks

lanitochka17 mentioned this pull request Jan 6, 2025

Tooltip - "Submit your expenses here" tooltip appears in the wrong location #54841

Open

8 tasks

Beamanator mentioned this pull request Jan 7, 2025

Login - FAB tooltip appears briefly after login when FAB tooltip is previously dismissed #54859

Open

8 tasks

linhvovan29546 mentioned this pull request Jan 7, 2025

fix: android native tooltip appears broken #54550

Merged

50 tasks

IuliiaHerets mentioned this pull request Jan 7, 2025

mWeb - Tooltip - The FAB Tooltip doesn't reappear when a modal is closed. #54867

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Make it possible to click the element the product training tooltip is pointing to #54710

Feat: Make it possible to click the element the product training tooltip is pointing to #54710

rayane-djouah commented Jan 1, 2025 •

edited

Loading

rayane-djouah commented Jan 2, 2025

melvin-bot bot commented Jan 2, 2025

ishpaul777 commented Jan 2, 2025 •

edited

Loading

ishpaul777 commented Jan 2, 2025

rayane-djouah commented Jan 2, 2025 •

edited

Loading

ishpaul777 commented Jan 2, 2025

ishpaul777 commented Jan 2, 2025

rayane-djouah commented Jan 3, 2025

rayane-djouah commented Jan 5, 2025

rayane-djouah commented Jan 6, 2025

ishpaul777 left a comment

puneetlath Jan 6, 2025

melvin-bot bot commented Jan 6, 2025

puneetlath commented Jan 6, 2025

OSBotify commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

izarutskaya commented Jan 7, 2025

	const isActiveRouteHome = useIsCurrentRouteHome();
	const isActiveRouteHome = useIsCurrentRouteHome();

Feat: Make it possible to click the element the product training tooltip is pointing to #54710

Feat: Make it possible to click the element the product training tooltip is pointing to #54710

Conversation

rayane-djouah commented Jan 1, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Concierge Chat Tooltip

FAB (Floating Action Button) Tooltip

QAB (Quick Action Button) Tooltip

Workspace Chat Tooltip

Filter Button Tooltip

Inbox Icon Tooltip

Saved search tooltip

"+" Button Tooltip in Invited Workspace

For all tooltips:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rayane-djouah commented Jan 2, 2025

melvin-bot bot commented Jan 2, 2025

ishpaul777 commented Jan 2, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jan 2, 2025

rayane-djouah commented Jan 2, 2025 • edited Loading

ishpaul777 commented Jan 2, 2025

ishpaul777 commented Jan 2, 2025

rayane-djouah commented Jan 3, 2025

rayane-djouah commented Jan 5, 2025

rayane-djouah commented Jan 6, 2025

ishpaul777 left a comment

Choose a reason for hiding this comment

puneetlath Jan 6, 2025

Choose a reason for hiding this comment

melvin-bot bot commented Jan 6, 2025

puneetlath commented Jan 6, 2025

OSBotify commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

izarutskaya commented Jan 7, 2025

rayane-djouah commented Jan 1, 2025 •

edited

Loading

ishpaul777 commented Jan 2, 2025 •

edited

Loading

rayane-djouah commented Jan 2, 2025 •

edited

Loading