Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-15] PR - Tooltip - The educational tooltip for a new account is wrong #54701

Closed
1 of 8 tasks
mitarachim opened this issue Jan 1, 2025 · 13 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Jan 1, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54344
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 14.6.1
App Component: Other

Action Performed:

1.Log in as User A, an account that owns a workspace
2.Create a new account B
3.On A, Invite B to the workspace
4.On B, open the workspace chat

Expected Result:

The tooltip shows over the composer's Create button saying "Get started! Submit your first expense"

Actual Result:

The educational tooltip for a new account over the composer's Create button says "Submit your expense" instead of "Get started! Submit your first expense"

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704693_1735686882683.Recording__322.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
@mitarachim mitarachim added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 1, 2025
Copy link

melvin-bot bot commented Jan 1, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@huult
Copy link
Contributor

huult commented Jan 1, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

The educational tooltip for a new account is wrong

What is the root cause of that problem?

We are using the WORKSPACE_CHAT_CREATE name to render the composer

const {renderProductTrainingTooltip, hideProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(
CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.WORKSAPCE_CHAT_CREATE,
shouldShowEducationalTooltip,
);

[WORKSAPCE_CHAT_CREATE]: {
content: [
{text: 'productTrainingTooltip.workspaceChatCreate.part1', isBold: true},
{text: 'productTrainingTooltip.workspaceChatCreate.part2', isBold: false},
],
onHideTooltip: () => dismissProductTraining(WORKSAPCE_CHAT_CREATE),
name: WORKSAPCE_CHAT_CREATE,
priority: 1100,
shouldShow: () => true,
},

and value text is Submit your and expenses

App/src/languages/en.ts

Lines 5593 to 5597 in e5108a1

workspaceChatCreate: {
part1: 'Submit your',
part2: ' expenses',
part3: ' here!',
},

What changes do you think we should make in order to solve the problem?

To resolve this issue, we just need to update the translation as expected in this ticket.

App/src/languages/en.ts

Lines 5593 to 5597 in e5108a1

workspaceChatCreate: {
part1: 'Submit your',
part2: ' expenses',
part3: ' here!',
},

        workspaceChatCreate: {
            part1: 'Get started! Submit your',
            part2: ' first expense',
            part3: ' here!',
        },
Screenshot 2025-01-01 at 13 24 10

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a translation issue; no unit test is needed

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@parasharrajat
Copy link
Member

Looks like a regression from #54263 cc: @ishpaul777

@ishpaul777
Copy link
Contributor

@rayane-djouah fixed this in this PR #54710

@rayane-djouah
Copy link
Contributor

Fixed in b7d5186

Copy link

melvin-bot bot commented Jan 6, 2025

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 6, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jan 7, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jan 7, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jan 7, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mallenexpensify
Copy link
Contributor

Confirming I see the tooltip, so closing. If a regression penalty is owed from this, please comment on the Issue from the associated PR that caused it. Thx
image

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Jan 8, 2025
@melvin-bot melvin-bot bot changed the title PR - Tooltip - The educational tooltip for a new account is wrong [HOLD for payment 2025-01-15] PR - Tooltip - The educational tooltip for a new account is wrong Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-15. 🎊

Copy link

melvin-bot bot commented Jan 8, 2025

@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants