Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sync>(project): Sync code from master. #577

Merged
merged 11 commits into from
Mar 1, 2022

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Mar 1, 2022

No description provided.

@ghost
Copy link

ghost commented Mar 1, 2022

Sider has detected 1 warning on analyzing the commit 6d978d2.

If the errors persist even after retrying, the following actions may resolve them:

If you still have problems, feel free to ask us via chat. 💬


You can turn off such notifications if unnecessary.

import org.fisco.bcos.sdk.client.protocol.model.JsonTransactionResponse;
import org.fisco.bcos.sdk.client.protocol.response.BcosBlock;
import org.fisco.bcos.sdk.client.protocol.response.BcosGroupNodeInfo;
import org.fisco.bcos.sdk.client.protocol.response.SystemConfig;
import org.fisco.bcos.sdk.client.protocol.response.TotalTransactionCount;
import org.fisco.bcos.sdk.codec.datatypes.Address;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Unused import - org.fisco.bcos.sdk.codec.datatypes.Address. (view)

Rule Severity
UnusedImportsCheck info

References:

You can close this issue if no need to fix it. Learn more.

@@ -59,7 +59,9 @@ public static void main(String[] args) {

WelcomeInfo.welcome();
String pwd = "/apps";
SupportedCommand.setIsAuthOpen(consoleInitializer.getClient().isAuthCheck());
SupportedCommand.setIsAuthOpen(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] The method 'main(String)' has a cognitive complexity of 81, current threshold is 15 (view)

Rule Ruleset Priority
CognitiveComplexity Design 3

References:

You can close this issue if no need to fix it. Learn more.

@@ -401,7 +401,9 @@ public void printUsageInfo() {
"Query code at a given address",
HelpInfo::getCodeHelp,
(consoleInitializer, params, pwd) ->
consoleInitializer.getConsoleClientFace().getCode(params),
consoleInitializer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Avoid really long classes. (view)

Rule Ruleset Priority
ExcessiveClassLength Design 3

References:

You can close this issue if no need to fix it. Learn more.

import org.fisco.bcos.sdk.client.protocol.model.JsonTransactionResponse;
import org.fisco.bcos.sdk.client.protocol.response.BcosBlock;
import org.fisco.bcos.sdk.client.protocol.response.BcosGroupNodeInfo;
import org.fisco.bcos.sdk.client.protocol.response.SystemConfig;
import org.fisco.bcos.sdk.client.protocol.response.TotalTransactionCount;
import org.fisco.bcos.sdk.codec.datatypes.Address;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Unused import 'org.fisco.bcos.sdk.codec.datatypes.Address' (view)

Rule Ruleset Priority
UnnecessaryImport Code Style 4

References:

You can close this issue if no need to fix it. Learn more.

@kyonRay kyonRay force-pushed the feature-3.0.0-rc3-sync branch from e564777 to 6d978d2 Compare March 1, 2022 08:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kyonRay kyonRay merged commit afc407a into FISCO-BCOS:feature-3.0.0-rc3 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants