Only apply Fabric Mixin services on platforms that need them #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixin provides its own bundled implementations on some other platforms (LaunchWrapper, ModLauncher) that can be used instead.
Juuxel
added a commit
to Juuxel/Spindle
that referenced
this pull request
Apr 4, 2023
This was referenced Apr 17, 2023
liach
reviewed
May 3, 2023
| public class MixinServiceKnotBootstrap implements IMixinServiceBootstrap { | ||
| public MixinServiceKnotBootstrap() { | ||
| if (!FabricLauncherBase.getLauncher().useFabricMixinServices()) { | ||
| // If an exception is thrown here, Mixin is designed to skip over this service. |
There was a problem hiding this comment.
Isn't the false return in MixinServiceKnot.isValid the way to prevent mixin from loading the service? Throwing an exception is costly and isn't a good way to prevent loading of service, as you have no way to distinguish it from other exceptions like ones generated from adding to an immutable list.
There was a problem hiding this comment.
Mixin itself does this in both the ModLauncher and LaunchWrapper implementations, albeit in bootstrap instead of the constructor and throwing a more precise exception (I somehow missed both of these details, will need to fix).
modmuss50
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixin provides its own bundled implementations on some other platforms (LaunchWrapper, ModLauncher) that can be used instead. As far as I can tell, this was the behaviour with LaunchWrapper before Knot was introduced in #37.