MinecraftGameProvider: Support split assets jar #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
LGTM, will need testing, especially in a split sources setup.
It is an intresting idea, as right now loom (wongly?) adds this file to both the client and server jar when splitting here: https://github.com/FabricMC/fabric-loom/blob/11f69ccbf0ed5660a3cf547685e2e2fc28581835/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/SplitMinecraftProvider.java#L79
Maybe moving the assets to their own jar would be a cleaner solution 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to #790. The older one is needed for ModLauncher support, this one is needed for running on ML together with Forge. Forge splits the MC assets into a separate jar on modern versions, so it needs to be recognised as an MC jar as well.
(If it's not recognised, random things like the detected MC version break.)