Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use .json extension for buffer files because there files are not actually valid json files #169

Closed
amityagov opened this issue Feb 27, 2021 · 6 comments · Fixed by #205
Assignees
Labels
bug Something isn't working

Comments

@amityagov
Copy link

Is your feature request related to a problem? Please describe.
*.json based buffer files are not valid json files actually.
Rider IDE tries to parse these files and hangs for quite some time.

Describe the solution you'd like
Please, add ability to specify buffer file extension.

@amityagov amityagov added the enhancement New feature or request label Feb 27, 2021
@github-actions
Copy link
Contributor

Hi there and welcome to this repository!

A maintainer will be with you shortly, but first and foremost I would like to thank you for taking the time to report this issue. Quality is of the highest priority for us, and we would never release anything with known defects. We aim to do our best but unfortunately you are here because you encountered something we didn't expect. Lets see if we can figure out what went wrong and provide a remedy for it.

@FantasticFiasco
Copy link
Owner

You are correct, the buffer files are not valid JSON, but they are also considered to be an implementation detail and not a part of the API. Changing the file extension would be a breaking change. I'm not sure the performance of Rider can motivate a breaking change.

@amityagov
Copy link
Author

amityagov commented Feb 27, 2021

Okay, maybe you can provide the way to change default behavior? Currently, it is not possible to change file extension for DurableHttpUsingFileSizeRolledBuffers, because it only has bufferBaseFileName parameter. However DurableHttpUsingTimeRolledBuffers has bufferPathFormat which allows developer to change file extension.

@FantasticFiasco
Copy link
Owner

We'll see what we can do. There are a lot of work planned ahead for this sink, let's see where this fits.

@FantasticFiasco FantasticFiasco added bug Something isn't working and removed enhancement New feature or request labels Mar 3, 2021
@rGunti
Copy link

rGunti commented Apr 7, 2021

@amityagov If it is still relevant for you: You can configure Rider to ignore the Buffer files so they don't chew away those CPU cycles.
Go to the Rider Settings > "Editor" > "Inspection Settings" > "Elements to Skip" and add the following file mask:
Buffer-*.json

image

@amityagov
Copy link
Author

@rGunti Hello, it helped, thanks.

FantasticFiasco added a commit that referenced this issue Jun 30, 2021
Let buffer files have the ".txt" extension instead of ".json", because even though the files contain JSON, they as a file are not a valid structured JSON object.

Fixes #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants