Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buffer file extension #205

Merged
merged 16 commits into from
Jun 30, 2021
Merged

Conversation

FantasticFiasco
Copy link
Owner

Change buffer file extensions from .json to .txt.

Fixes #169

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #205 (ddaa8d1) into master (8cf1a9f) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   91.04%   90.83%   -0.21%     
==========================================
  Files          30       30              
  Lines         860      884      +24     
==========================================
+ Hits          783      803      +20     
- Misses         77       81       +4     
Impacted Files Coverage Δ
...og.Sinks.Http/LoggerSinkConfigurationExtensions.cs 100.00% <ø> (ø)
...nks.Http/Sinks/Http/Private/IO/DirectoryService.cs 100.00% <ø> (ø)
.../Http/Private/Durable/FileSizeRolledBufferFiles.cs 100.00% <100.00%> (ø)
...p/Private/Durable/FileSizeRolledDurableHttpSink.cs 100.00% <100.00%> (ø)
...inks/Http/Private/Durable/TimeRolledBufferFiles.cs 100.00% <100.00%> (ø)
.../Http/Private/Durable/TimeRolledDurableHttpSink.cs 100.00% <100.00%> (ø)
....Http/Sinks/Http/Private/Durable/HttpLogShipper.cs 81.72% <0.00%> (-4.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de79d4...ddaa8d1. Read the comment docs.

@FantasticFiasco FantasticFiasco merged commit d834dff into master Jun 30, 2021
@FantasticFiasco FantasticFiasco deleted the fix/buffer-file-extension branch June 30, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use .json extension for buffer files because there files are not actually valid json files
1 participant