Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TabLine* highlights, improve Nvim-Tree visibility, follow background setting, and use main theme colours for Lualine #11

Merged
merged 4 commits into from
Dec 22, 2021

Conversation

Slotos
Copy link
Contributor

@Slotos Slotos commented Dec 21, 2021

Granted, this is a mess of four incremental changes, please tell me if you'd prefer to see them as four separate PRs.

These changes implement, each in a separate commit:

  • TabLine, TabLineSel, and TabLineFill highlight groups - something important for anyone who's using tab groups
  • Use of background setting, as opposed to forcing it - now colours change as you change your background
  • Fix for nvim-tree.lua folders color matching background color in light palette - a color that matches the position of the dark palette was selected instead
  • lualine dynamic color switching, using central definition of theme colors - any future updates to this theme will propagate to lualine (lightline and airline would take too much time for me, my apologies)

Here's how it looks now with lualine and a heavily modified luatab:

Dark background
image

Light background, as a reaction to set background=light
image

Mish style, with theme reload
image

Gui02 light color was replaces with the color
corresponding to dark one in the palette.
This fixes nvim-tree folder names visibility in
light mode.
This allows me to propagate the changes to lualine
without the need to keep text files in sync.
Additionally, this implements all three styles
for the theme for lualine, without extra definitions.

TODO:
- Lightline.
  It requires cterm color definitions, making it a trickier mapping.
- Airline.
Copy link
Owner

@FrenzyExists FrenzyExists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is a HUGE update. This color propagation that you made which could reload when theme is changed is what I indeed wanted, but didn't exactly knew how to achieve it. Really appreciate the contribution!

@FrenzyExists FrenzyExists merged commit a21ca6b into FrenzyExists:develop Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants