allow Symfony 4.0 requirements #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we run tests using it? |
xabbuh
force-pushed
the
symfony-4.0
branch
3 times, most recently
from
ae3c436 to
2f906dc
Compare
xabbuh
force-pushed
the
symfony-4.0
branch
6 times, most recently
from
4d1e632 to
44b9d9e
Compare
|
done |
GuilhemN
reviewed
May 21, 2017
| "phpoption/phpoption": "^1.1", | ||
| "jms/serializer-bundle": "^1.0", | ||
| "psr/http-message": "^1.0" | ||
| }, | ||
| "minimum-stability": "dev", |
There was a problem hiding this comment.
Can't we just require 4.0.*@dev instead ?
There was a problem hiding this comment.
We can if you prefer that. :)
There was a problem hiding this comment.
It's fine for me as long as we don't have problems, just tests are more likely to break with this setting.
Let's keep it this way for now, we'll see soon enough if it causes issues :)
|
Thank you @xabbuh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.