compatibility with Symfony 4 #576
Conversation
xabbuh
force-pushed
the
patch-1
branch
3 times, most recently
from
2d3de13 to
f04085d
Compare
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^4.2|^5.0", | ||
| "symfony/expression-language": "~2.6|~3.0", | ||
| "phpunit/phpunit": "^4.8.35|^5.4.3|^6.0", |
There was a problem hiding this comment.
just out of curiosity, is there any special reason to require explicitly 4.8.35 or 5.4.3 instead of 4.8, 5.4 ?
There was a problem hiding this comment.
We need ^6.0 to be able to install the Yaml component in version 4 (older PHPUnit versions depended on 2.x/3.x while PHPUnit 6 completely dropped the requirement of the Yaml component). However, PHPUnit 6 does not have the old \PHPUnit_Framework_TestCase class so that we need to change the base class of all test cases to use the TestCase class from the PHPUnit\Framework namespace. This in turn requires us to bump the dependency for PHPUnit 4 and 5 to releases that included class aliases for the namespaced TestCase class as a FC layer.
There was a problem hiding this comment.
:-/ I was (and still I am) OK with the changes for phpunit 6.0 ( and for the changes required for it), my question was about the changes regarding 4.8 and 5.4
😄
There was a problem hiding this comment.
Just wanted to explain the whole reasoning here in case someone find this change in the future and needs some explanation. :)
There was a problem hiding this comment.
@goetas I think the changes for 4.8 and 5.4 are needed because only starting with those, the class aliases have been set-up.
|
nice :) has it been already decided the release date for sf 4? |
Symfony 4 will be released by the end of November/the beginning of December (see http://symfony.com/roadmap?version=4.0#checker). |
|
The min stability dev was a bad idea imo
…On 26 Jun 2017 11:52, "Johannes" ***@***.***> wrote:
Merged #576 <#576>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#576 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvaJ5M7LI0N6MIOQEgujyM22P5ZH-8pks5sH39egaJpZM4Nhlrw>
.
|
|
Having stability "dev" will constantly bring unstable dependencies, and false failures will be more frequent. Why not put @dev on the dependent libs? |
|
We should probably use the |
|
That will help
…On 26 Jun 2017 12:39, "Christian Flothmann" ***@***.***> wrote:
We should probably use the --prefer-stable option by default.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#576 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvaJ-1TrGz4X0wjeuDczLBvcMVpSH-pks5sH4p4gaJpZM4Nhlrw>
.
|
|
see #588 |
|
Shouldn't this also require |
|
@sgrodzicki why? |
|
@goetas since the Translation component is no longer a dependency of the FrameworkBundle: symfony/framework-bundle@a1382b4#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 Way to reproduce the issue: composer create-project symfony/skeleton pr576 \
&& cd pr576 \
&& composer req cli jms/serializer-bundle |
|
@sgrodzicki it is on the way, see schmittjoh/serializer#824 |
In FOSRestBundle, we need this to test for compatibility with Symfony 4 (see FriendsOfSymfony/FOSRestBundle#1708).