Modify block producer to take into account the total gas used by the L1 transactions

[MitchTurner]

closes #1750

[Voxelot]

While probably very unlikely (and should be prevented by the contract on L1), I wonder if we need to do anything here to handle an overflow in case the cumulative max_gas is somehow too large.

[MitchTurner]

I'll change it to a saturated add and fold.

[xgreenx]

Could you revert back indent changes in this file, please?=)

[xgreenx]

I'm afraid that the current usage of the Genesis da block height will lead to iterations from 0..5M.

It may not be a huge problem in the long term, but it may slow down the start of the fuel core for local development.

[xgreenx]

It would be nice, maybe, to move this logic to block producer.

In this case, the block producer will have control over the number of iterations. Because we had a long delay/finalization and we have 100 blocks with a maxed gas limit, you will do 100 iterations while you need only one.

We could use something like:

#[async_trait::async_trait]
pub trait Relayer: Send + Sync {
    /// Wait for the relayer to reach at least this height and return the
    /// latest height (which is guaranteed to be >= height).
    async fn wait_for_at_least(
        &self,
        height: &DaBlockHeight,
    ) -> anyhow::Result<DaBlockHeight>;

    /// Returns the gas cost of events at the given height.
    async fn gas_cost_at_height(
        &self,
        height: &DaBlockHeight,
    ) -> anyhow::Result<Word>;
}

[xgreenx]

You don't need to call into_owned here. It is the place where we want to use references if possible.

[xgreenx]

Why do we want to lose these tests?

[MitchTurner]

Added some tests on Task for the same coverage.

[xgreenx]

Suggested change

	for height in previous_da_height.0..=heighest.0 {
	for height in previous_da_height.0 + 1..=heighest.0 {

We've already included events at previous_da_height, so we need to skip it. Otherwise, we will stuck on that height forever.

I think it also would be nice to add a test to test that case where each da height contains transactions to fill block_gas_limit