-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Produce block when da height haven't changed #1803
Merged
xgreenx
merged 2 commits into
master
from
bugfix/fixed-produciton-if-height-havent-changed
Apr 4, 2024
Merged
Fix: Produce block when da height haven't changed #1803
xgreenx
merged 2 commits into
master
from
bugfix/fixed-produciton-if-height-havent-changed
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Good catch. I'm confused why we were able to merge before despite this being broken.
MitchTurner
approved these changes
Apr 4, 2024
Merged
xgreenx
added a commit
that referenced
this pull request
Apr 5, 2024
## Version v0.24.2 ### Changed #### Breaking - [#1798](#1798): add nonce to relayed transactions and also hash full messages in the inbox root. ### Fixed - [#1802](#1802): Fixed a runtime panic that occurred when restarting a node. The panic was caused by an invalid database commit while loading an existing off-chain database. The invalid commit is removed in this PR. - [#1803](#1803): Produce block when da height haven't changed. - [#1795](#1795): Fixed the building of the `fuel-core-wasm-executor` to work outside of the `fuel-core` context. The change uses the path to the manifest file of the `fuel-core-upgradable-executor` to build the `fuel-core-wasm-executor` instead of relying on the workspace. ## What's Changed * Weekly `cargo update` by @github-actions in #1794 * Improvements for the `fuel-core-upgradable-executor` build script by @xgreenx in #1795 * Use full hash for messages in inbox_root and add nonce to relayed transactions by @Voxelot in #1798 * Modify block producer to take into account the total gas used by the L1 transactions by @MitchTurner in #1785 * Fix: Produce block when da height haven't changed by @xgreenx in #1803 * fix: Fix commit error on GraphQL service startup by @bvrooman in #1802 **Full Changelog**: v0.24.1...v0.24.2
crypto523
pushed a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## Version v0.24.2 ### Changed #### Breaking - [#1798](FuelLabs/fuel-core#1798): add nonce to relayed transactions and also hash full messages in the inbox root. ### Fixed - [#1802](FuelLabs/fuel-core#1802): Fixed a runtime panic that occurred when restarting a node. The panic was caused by an invalid database commit while loading an existing off-chain database. The invalid commit is removed in this PR. - [#1803](FuelLabs/fuel-core#1803): Produce block when da height haven't changed. - [#1795](FuelLabs/fuel-core#1795): Fixed the building of the `fuel-core-wasm-executor` to work outside of the `fuel-core` context. The change uses the path to the manifest file of the `fuel-core-upgradable-executor` to build the `fuel-core-wasm-executor` instead of relying on the workspace. ## What's Changed * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1794 * Improvements for the `fuel-core-upgradable-executor` build script by @xgreenx in FuelLabs/fuel-core#1795 * Use full hash for messages in inbox_root and add nonce to relayed transactions by @Voxelot in FuelLabs/fuel-core#1798 * Modify block producer to take into account the total gas used by the L1 transactions by @MitchTurner in FuelLabs/fuel-core#1785 * Fix: Produce block when da height haven't changed by @xgreenx in FuelLabs/fuel-core#1803 * fix: Fix commit error on GraphQL service startup by @bvrooman in FuelLabs/fuel-core#1802 **Full Changelog**: FuelLabs/fuel-core@v0.24.1...v0.24.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.