Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Produce block when da height haven't changed #1803

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Apr 4, 2024

No description provided.

@xgreenx xgreenx requested review from MitchTurner and a team April 4, 2024 13:06
@xgreenx xgreenx self-assigned this Apr 4, 2024
@xgreenx xgreenx enabled auto-merge (squash) April 4, 2024 13:07
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Good catch. I'm confused why we were able to merge before despite this being broken.

@xgreenx
Copy link
Collaborator Author

xgreenx commented Apr 4, 2024

Actually, it failed=D But yeah, it is strange why we even merged it with failed tests.

image

@MitchTurner MitchTurner disabled auto-merge April 4, 2024 15:13
@xgreenx xgreenx merged commit 03195c1 into master Apr 4, 2024
33 checks passed
@xgreenx xgreenx deleted the bugfix/fixed-produciton-if-height-havent-changed branch April 4, 2024 15:14
@xgreenx xgreenx mentioned this pull request Apr 4, 2024
xgreenx added a commit that referenced this pull request Apr 5, 2024
## Version v0.24.2

### Changed

#### Breaking
- [#1798](#1798): add nonce to
relayed transactions and also hash full messages in the inbox root.

### Fixed

- [#1802](#1802): Fixed a
runtime panic that occurred when restarting a node. The panic was caused
by an invalid database commit while loading an existing off-chain
database. The invalid commit is removed in this PR.
- [#1803](#1803): Produce
block when da height haven't changed.
- [#1795](#1795): Fixed the
building of the `fuel-core-wasm-executor` to work outside of the
`fuel-core` context. The change uses the path to the manifest file of
the `fuel-core-upgradable-executor` to build the
`fuel-core-wasm-executor` instead of relying on the workspace.

## What's Changed
* Weekly `cargo update` by @github-actions in
#1794
* Improvements for the `fuel-core-upgradable-executor` build script by
@xgreenx in #1795
* Use full hash for messages in inbox_root and add nonce to relayed
transactions by @Voxelot in
#1798
* Modify block producer to take into account the total gas used by the
L1 transactions by @MitchTurner in
#1785
* Fix: Produce block when da height haven't changed by @xgreenx in
#1803
* fix: Fix commit error on GraphQL service startup by @bvrooman in
#1802


**Full Changelog**:
v0.24.1...v0.24.2
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
## Version v0.24.2

### Changed

#### Breaking
- [#1798](FuelLabs/fuel-core#1798): add nonce to
relayed transactions and also hash full messages in the inbox root.

### Fixed

- [#1802](FuelLabs/fuel-core#1802): Fixed a
runtime panic that occurred when restarting a node. The panic was caused
by an invalid database commit while loading an existing off-chain
database. The invalid commit is removed in this PR.
- [#1803](FuelLabs/fuel-core#1803): Produce
block when da height haven't changed.
- [#1795](FuelLabs/fuel-core#1795): Fixed the
building of the `fuel-core-wasm-executor` to work outside of the
`fuel-core` context. The change uses the path to the manifest file of
the `fuel-core-upgradable-executor` to build the
`fuel-core-wasm-executor` instead of relying on the workspace.

## What's Changed
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#1794
* Improvements for the `fuel-core-upgradable-executor` build script by
@xgreenx in FuelLabs/fuel-core#1795
* Use full hash for messages in inbox_root and add nonce to relayed
transactions by @Voxelot in
FuelLabs/fuel-core#1798
* Modify block producer to take into account the total gas used by the
L1 transactions by @MitchTurner in
FuelLabs/fuel-core#1785
* Fix: Produce block when da height haven't changed by @xgreenx in
FuelLabs/fuel-core#1803
* fix: Fix commit error on GraphQL service startup by @bvrooman in
FuelLabs/fuel-core#1802


**Full Changelog**:
FuelLabs/fuel-core@v0.24.1...v0.24.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants