-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Replace hmm
with HxPKG
#3741
Conversation
That issue happens because hxCodec needs to be installed globally, by the way |
It doesn't need to be installed globally
|
woah its real i haven't tested installing hxCodec with hxpkg |
I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment) |
haxe moment |
You can't do that with hmm |
This PR uses HxPKG, so, it'll be a thing for HxPKG, not for hmm |
Extra info |
HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg This is a temporary fix until Haxe 5.0 comes out |
hxCodec is always installed globally through hxpkg |
If someone could teach me how to re-base (so I can delete that pesky CHANGELOG commit) and sync branches from the correct branch, that'd be fuckin' wonderful LOL |
@ninjamuffin99 sorry for the @, but, since you're the Git guru around here, is there a way you can fix the "duplicate" commits from appearing? |
7cf45de
to
558b05a
Compare
Squashed the commits, did a few changes, this should be a-okay now! |
Co-authored-by: CobaltBar <[email protected]> Co-authored-by: lemz1 <[email protected]>
Keeping the cache in, as that's important, but the setup isn't, as HxPKG automatically sets up hxcpp for you
Turns out that lime step is important
Bumped versions for all libraries, replaced everything regarding hmm within the compiling documentation, add .hxpkg to .gitattributes to use JSON as the display language
If the underlying issue got resolved in |
It was a haxelib issue, and the fix won't be released until haxe 5 (iirc) |
It has been clarified in polybiusproxy/hxCodec#300 (comment) that it was actually a But if it does fix how hmm screws up installs then that'd be actually very cool. |
not to mention that |
If anything, |
Does this PR close any issues? If so, link them below.
#2360, #2341, #1326 (comment), #1326 (comment)
Briefly describe the issue(s) fixed.
Temporary solution with HxPKG is to force install libraries that have C++ files included in them, such as hxCodec and hxdiscord_rpc.
The fix has already been merged internally within the hxcpp repository.
Global installs of said libraries will be reverted once Haxe 5.0.0 releases.
See: polybiusproxy/hxCodec#300 (comment), HaxeFoundation/haxelib#618 for more details on the issue.
Description
HxPKG, just like HMM, is a Haxe library/module manager that installs libraries with a singular command, locally.
For more on how to use HxPKG, read here, to submit issues for the library directly, click here.
Changelog:
Note
Additional testing from the Funkin' Crew's side is required, as to make sure that their internal workflow isn't disrupted by this change.
Special Thanks
@CCobaltDev for HxPKG
@lemz1 for editing the macros to work with HxPKG
Include any relevant screenshots or videos.
N/A