Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Replace hmm with HxPKG #3741

Closed
wants to merge 8 commits into from

Conversation

doggogit
Copy link
Contributor

@doggogit doggogit commented Oct 20, 2024

Does this PR close any issues? If so, link them below.

#2360, #2341, #1326 (comment), #1326 (comment)

Briefly describe the issue(s) fixed.

Temporary solution with HxPKG is to force install libraries that have C++ files included in them, such as hxCodec and hxdiscord_rpc.

The fix has already been merged internally within the hxcpp repository.

Global installs of said libraries will be reverted once Haxe 5.0.0 releases.

See: polybiusproxy/hxCodec#300 (comment), HaxeFoundation/haxelib#618 for more details on the issue.

Description

HxPKG, just like HMM, is a Haxe library/module manager that installs libraries with a singular command, locally.

For more on how to use HxPKG, read here, to submit issues for the library directly, click here.

Changelog:

  • Replaced HMM with HxPKG
    • With this, all labels, code, workflows and setup processes have been modified to fit HxPKG

Note

Additional testing from the Funkin' Crew's side is required, as to make sure that their internal workflow isn't disrupted by this change.

Special Thanks

@CCobaltDev for HxPKG
@lemz1 for editing the macros to work with HxPKG

Include any relevant screenshots or videos.

N/A

@github-actions github-actions bot added pr: documentation PR modifies documentation or README files. size: large A large pull request with more than 100 changes. labels Oct 20, 2024
@biomseed
Copy link

That issue happens because hxCodec needs to be installed globally, by the way

@doggogit
Copy link
Contributor Author

doggogit commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

It doesn't need to be installed globally

HxPKG remedies that issue as it's something with some flag, I don't exactly know..

@CCobaltDev
Copy link

CCobaltDev commented Oct 20, 2024

woah its real

i haven't tested installing hxCodec with hxpkg

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

@CCobaltDev
Copy link

haxe moment
i'll just add a thing to force global installation of hxCodec

@biomseed
Copy link

haxe moment i'll just add a thing to force global installation of hxCodec

You can't do that with hmm

@doggogit
Copy link
Contributor Author

haxe moment i'll just add a thing to force global installation of hxCodec

You can't do that with hmm

This PR uses HxPKG, so, it'll be a thing for HxPKG, not for hmm

@CCobaltDev
Copy link

CCobaltDev commented Oct 20, 2024

Extra info
hxpkg works in github actions
to install the packages for testing along with the ones for testing its hxpkg install unit

@doggogit
Copy link
Contributor Author

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg

This is a temporary fix until Haxe 5.0 comes out

@CCobaltDev
Copy link

CCobaltDev commented Oct 20, 2024

That issue happens because hxCodec needs to be installed globally, by the way

I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment)

HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg

This is a temporary fix until Haxe 5.0 comes out

hxCodec is always installed globally through hxpkg
not ideal but I can't do much about it

@doggogit
Copy link
Contributor Author

If someone could teach me how to re-base (so I can delete that pesky CHANGELOG commit) and sync branches from the correct branch, that'd be fuckin' wonderful LOL

@doggogit doggogit closed this Oct 23, 2024
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Oct 23, 2024
@doggogit doggogit reopened this Oct 23, 2024
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed size: small A small pull request with 10 or fewer changes. labels Oct 23, 2024
@doggogit
Copy link
Contributor Author

@ninjamuffin99 sorry for the @, but, since you're the Git guru around here, is there a way you can fix the "duplicate" commits from appearing?

@doggogit doggogit force-pushed the hxpkg branch 2 times, most recently from 7cf45de to 558b05a Compare October 23, 2024 12:52
@doggogit doggogit marked this pull request as ready for review October 23, 2024 12:56
@doggogit
Copy link
Contributor Author

Squashed the commits, did a few changes, this should be a-okay now!

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. and removed pr: documentation PR modifies documentation or README files. labels Jan 22, 2025
@AbnormalPoof AbnormalPoof added the pr: documentation PR modifies documentation or README files. label Jan 26, 2025
doggogit and others added 8 commits February 5, 2025 12:33
Co-authored-by: CobaltBar <[email protected]>
Co-authored-by: lemz1 <[email protected]>
Keeping the cache in, as that's important, but the setup isn't, as HxPKG automatically sets up hxcpp for you
Turns out that lime step is important
Bumped versions for all libraries, replaced everything regarding hmm within the compiling documentation, add .hxpkg to .gitattributes to use JSON as the display language
@github-actions github-actions bot added the pr: github PR modifies GitHub metadata files. label Feb 5, 2025
@EliteMasterEric
Copy link
Member

EliteMasterEric commented Feb 7, 2025

If the underlying issue got resolved in hxcpp why do we need this change

@AbnormalPoof AbnormalPoof added status: needs clarification Requires more info from the author. and removed status: pending triage Awaiting review. labels Feb 7, 2025
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed type: enhancement Involves an enhancement or new feature. status: needs clarification Requires more info from the author. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. labels Feb 7, 2025
@CCobaltDev
Copy link

If the underlying issue got resolved in hxcpp why do we need this change

It was a haxelib issue, and the fix won't be released until haxe 5 (iirc)
And it fixes some library installs being goofy

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Feb 7, 2025

It was a haxelib issue, and the fix won't be released until haxe 5 (iirc)

It has been clarified in polybiusproxy/hxCodec#300 (comment) that it was actually a hxcpp issue.

But if it does fix how hmm screws up installs then that'd be actually very cool.

@charlesisfeline
Copy link

charlesisfeline commented Feb 7, 2025

not to mention that hxvlc will be replacing hxCodec in the next update (afaik) so i dont see much of the point either tbh

@doggogit
Copy link
Contributor Author

doggogit commented Feb 8, 2025

If anything, hxpkg got some cool additions and features, gonna delete the branch now

@doggogit doggogit deleted the hxpkg branch February 8, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants