Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering Error with RDNA2 #36

Closed
Azralee opened this issue Feb 26, 2021 · 1 comment · Fixed by #37
Closed

Rendering Error with RDNA2 #36

Azralee opened this issue Feb 26, 2021 · 1 comment · Fixed by #37

Comments

@Azralee
Copy link
Contributor

Azralee commented Feb 26, 2021 •
edited
Loading

I noticed a weird rendering error in scene 2:
Metallic
Swapping the material of the affected sphere out to Material::Lambertian(vec3(1.0f),1) resolves the issue:
grafik
Switching the center Spere to Material::Metallic(vec3(1.0f), 0.0f) causes the issue to also affect this sphere:
grafik

This is on an RX 6800 on the 21.2.2 driver.
Azralee pushed a commit to Azralee/RayTracingInVulkan that referenced this issue Feb 28, 2021
Update scatter.glsl to fix issue with textures
773b1e9 
This proposed change fixes GPSnoopy#36 without any visual impact.
@Azralee
Copy link
Contributor Author

Azralee commented Feb 28, 2021

I filed a patch to fix the issue. Here is RT in one weekend after the Fix:
grafik
And Planets in one weekend:
grafik

@Azralee Azralee mentioned this issue Feb 28, 2021
Merged
Azralee pushed a commit to Azralee/RayTracingInVulkan that referenced this issue Mar 1, 2021
Update scatter.glsl to fix texture issues on RDNA2
3c35f43 
This change fixes GPSnoopy#36 without any visual impact.
The problem resulted from non-specified nonuniform texture indices.
As the compiler is allowed to assume uniformity in certain variables, unless specified, this was a bug.
https://github.com/KhronosGroup/GLSL/blob/master/extensions/ext/GL_EXT_nonuniform_qualifier.txt
GPSnoopy pushed a commit that referenced this issue Mar 28, 2021
Update scatter.glsl to fix issue with textures (#37)
ca6732a 
* Update scatter.glsl to fix texture issues on RDNA2

This change fixes #36 without any visual impact.
The problem resulted from non-specified nonuniform texture indices.
As the compiler is allowed to assume uniformity in certain variables, unless specified, this was a bug.
https://github.com/KhronosGroup/GLSL/blob/master/extensions/ext/GL_EXT_nonuniform_qualifier.txt

* Update Scatter.glsl to include extensions

* Remove extraneous #version

* Update Scatter.glsl to fix a corner case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update scatter.glsl to fix issue with textures Azralee/RayTracingInVulkan
1 participant
@Azralee