Refactor to addess issues #19 #23 #24 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artisan expect script
Added ldap: var to check for when conditional in tasks/main.yml to simplify
ldapdict no longer seems available anyway)
|
@sacres , thanks for your contribution. |
|
And thanks for the merge @GR360RY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
To fix: #19 ; as this is due to changes in the questions
ldapdict seems to have 'gone away' , to work around this:
created the ldap: var and use this for the conditional (saves on [un]commenting as well).
Added some env lookups (will use the defaults/main.yml vars if they don't exist, i.e. the GIT_AUTHOR_EMAIL)
Added vars_prompt (with accompanying defaults) for passwords.