Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React common component: Popup #36

Open
SajedaIsmail opened this issue Sep 22, 2019 · 0 comments
Open

React common component: Popup #36

SajedaIsmail opened this issue Sep 22, 2019 · 0 comments
Assignees
@SajedaIsmail
Labels
Common Component Done The technical tasks related to this issue are done Frontend This issue/PR is related to Frontend project

Comments

@SajedaIsmail
Copy link
Collaborator

The popup component will :

  • Be a div with white background.
  • Has an image in the top.
  • Has a text in the middle.
  • Has a button for a specific action, this button will be invoked as another common component.

image

Relates #31
@SajedaIsmail SajedaIsmail added To do This issue represents a technical task that is yet to be started on Frontend This issue/PR is related to Frontend project Common Component labels Sep 22, 2019
@SajedaIsmail SajedaIsmail added In progress This issue/PR represents a technical task that is currently being worked on and removed To do This issue represents a technical task that is yet to be started on labels Sep 25, 2019
SajedaIsmail added a commit that referenced this issue Sep 25, 2019
@SajedaIsmail
common popup component is created and styled
c02c625 
Relates #36
@SajedaIsmail SajedaIsmail mentioned this issue Sep 25, 2019
Merged
SajedaIsmail added a commit that referenced this issue Sep 29, 2019
@SajedaIsmail
A prop for defining if the pop up has one or tow buttons is added
2a7b352 
the Roboto font family is used
the background color is black and lighter
Relates #36
SajedaIsmail added a commit that referenced this issue Sep 30, 2019
@SajedaIsmail
the common button component is used in the popup component
54f8b9d 
media query added for the larger screens to make the popup more responsive
Relates #36
SajedaIsmail added a commit that referenced this issue Sep 30, 2019
@SajedaIsmail
Fixed some styling issues
fb385c1 
add the buttons name props
Relates #36
@MohammadAlhalaq MohammadAlhalaq added Done The technical tasks related to this issue are done and removed In progress This issue/PR represents a technical task that is currently being worked on labels Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SajedaIsmail SajedaIsmail

Labels
Common Component Done The technical tasks related to this issue are done Frontend This issue/PR is related to Frontend project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MohammadAlhalaq @SajedaIsmail