common popup component is created and styled #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SajedaIsmail
requested review from
MohammadAlhalaq,
ahmedisam99,
ranasobeid95 and
alaa-yasin
MohammadAlhalaq
previously approved these changes
Sep 28, 2019
the Roboto font family is used the background color is black and lighter Relates #36
ahmedisam99
previously approved these changes
Sep 29, 2019
There was a problem hiding this comment.
Wait for #55 to be merged and then use the common button from it
ahmedisam99
added
Approved
ranasobeid95
previously approved these changes
Sep 29, 2019
| <div className="popup"> | ||
| <img src={img} alt="food" className="popup-img" /> | ||
| <p className="popup-text"> {message} </p> | ||
| <button type="submit" className="popup-button"> |
There was a problem hiding this comment.
Why you didn't use Button component
| .popup{ | ||
| position: absolute; | ||
| text-align: center; | ||
| width: 80%; |
There was a problem hiding this comment.
Suggestion you can use vw vh
Suggested change
| width: 80%; | |
| width: 80vw; |
alaa-yasin
previously approved these changes
Sep 30, 2019
media query added for the larger screens to make the popup more responsive Relates #36
SajedaIsmail
dismissed stale reviews from alaa-yasin, ranasobeid95, and ahmedisam99
via
54f8b9d
ranasobeid95
previously approved these changes
Sep 30, 2019
MohammadAlhalaq
previously approved these changes
Sep 30, 2019
ahmedisam99
added
Changes Requested
add the buttons name props Relates #36
SajedaIsmail
dismissed stale reviews from MohammadAlhalaq and ranasobeid95
via
d417616
SajedaIsmail
added
Awaiting Review
ahmedisam99
approved these changes
Sep 30, 2019
ahmedisam99
added
Approved
MohammadAlhalaq
approved these changes
Sep 30, 2019
alaa-yasin
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #36