Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Field] refactoring and update #112

Merged
merged 28 commits into from
Nov 23, 2020
Merged

[Field] refactoring and update #112

merged 28 commits into from
Nov 23, 2020

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Nov 18, 2020

Overall

  • drop usage of pos2xyz and xyz2pos

Generators

  • remove structured option from generators (structured pos need to be converted first)
  • explicitly assert dim=2,3 when generating vector fields

Tools

  • remove routines pos2xyz and xyz2pos (finally)
  • add routines to format struct. pos tuple by given dim or shape
  • add routine to format struct. pos tuple by given shape (variogram helper)
  • remove field.tools subpackage

Field

  • simplify pre_pos routine to save pos tuple and reformat it an unstructured tuple
  • simplify field shaping
  • simplify plotting routines

SRF/Krige

  • simplify generation and conditioning

Mesh

  • support meshio>=4.0
  • add meshio as dependency
  • add example

@MuellerSeb MuellerSeb added enhancement New feature or request Refactoring Code-Refactoring needed here labels Nov 18, 2020
@MuellerSeb MuellerSeb added this to the 1.3 milestone Nov 18, 2020
@MuellerSeb MuellerSeb requested a review from LSchueler November 18, 2020 23:35
@MuellerSeb MuellerSeb self-assigned this Nov 18, 2020
@MuellerSeb MuellerSeb marked this pull request as draft November 19, 2020 01:08
@MuellerSeb MuellerSeb marked this pull request as ready for review November 19, 2020 17:05
@MuellerSeb
Copy link
Member Author

@LSchueler should be ready for a first glimpse.

@MuellerSeb
Copy link
Member Author

MuellerSeb commented Nov 23, 2020

@LSchueler there is still a bug in format_unstruct_pos_shape that needs to be tackled by me. Just to keep that in mind.

Edit: Solved.

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already looking so great!

As always, I've fixed some typos, so remember to pull before doing new commits.

I guess the gstools.field.summator.summate_{unstruct,summate_incompr_unstruct} should be renamed. The _unstruct is probably only confusing from now on. Or what reasons are there to keep the name? The name could be summate_modes if you don't like summator.summate.

Apart from that, I don't have too much to add at the moment, except maybe: great job!

gstools/__init__.py Show resolved Hide resolved
gstools/field/base.py Show resolved Hide resolved
gstools/krige/tools.py Show resolved Hide resolved
gstools/krige/tools.py Show resolved Hide resolved
tests/test_randmeth.py Outdated Show resolved Hide resolved
tests/test_incomprrandmeth.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Refactoring Code-Refactoring needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants