Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifactregistry: fix comments, more examples for common remote repositories #12312

Merged
merged 10 commits into from
Nov 15, 2024

Conversation

Gridasov
Copy link
Member

@Gridasov Gridasov commented Nov 13, 2024

Common repositories for Artifact Registry can accept the following resources:

  • URI to another Artifact Registry instance
  • URI to external registries

This PR fixes comments for google_artifact_registry_repository and adds corresponding examples.


@github-actions github-actions bot requested a review from NickElliot November 13, 2024 01:53
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 270 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 270 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 25
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 25
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithCustomUpstreamExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 270 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 270 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 235 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 223 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 264 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 223 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 223 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 264 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 223 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 223 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 264 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 26
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • artifactregistry

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteCommonRepositoryWithArtifactRegistryUriExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 27
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • artifactregistry

🟢 All tests passed!

View the build log

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@Gridasov Gridasov requested a review from yihanzhen November 15, 2024 18:44
@yihanzhen
Copy link
Member

LGTM

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickElliot NickElliot merged commit e7cf93b into GoogleCloudPlatform:main Nov 15, 2024
15 checks passed
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
…itories (GoogleCloudPlatform#12312)

Co-authored-by: Yury Gridasov <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Ian Milligan <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
…itories (GoogleCloudPlatform#12312)

Co-authored-by: Yury Gridasov <[email protected]>
Co-authored-by: Will Yardley <[email protected]>
Co-authored-by: Ian Milligan <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants