fix: datacatalog taxonomy import project from name #7137

ekapratama93 · 2023-01-18T10:09:12Z

Fixes hashicorp/terraform-provider-google#13307

This is re-attempt to merge #7063 with small change.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog: fixed the import failure when the `project` is different from the default on `google_data_catalog_taxonomy`

Signed-off-by: ekapratama93 <[email protected]>

google-cla · 2023-01-18T10:09:18Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2023-01-18T10:10:18Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-01-18T10:24:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 1 file changed, 7 insertions(+))

modular-magician · 2023-01-18T11:14:49Z

Tests analytics

Total tests: 2423
Passed tests 2169
Skipped tests: 252
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful

modular-magician · 2023-01-18T11:18:28Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Signed-off-by: ekapratama93 <[email protected]>

modular-magician · 2023-01-18T13:06:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-18T13:54:46Z

Tests analytics

Total tests: 2423
Passed tests 2169
Skipped tests: 252
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful

modular-magician · 2023-01-18T13:58:28Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

ekapratama93 · 2023-01-18T15:52:38Z

Running acceptance test for TestAccRegionInstanceGroupManager_stateful in my local environment was successful on this changes. But it does need to be retried for three times 🤷 .

make testacc TEST=./google-beta TESTARGS='-run=TestAccRegionInstanceGroupManager_stateful'
==> Checking that code complies with gofmt requirements...
go vet
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccRegionInstanceGroupManager_stateful -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccRegionInstanceGroupManager_stateful
=== PAUSE TestAccRegionInstanceGroupManager_stateful
=== CONT  TestAccRegionInstanceGroupManager_stateful
--- PASS: TestAccRegionInstanceGroupManager_stateful (416.06s)
PASS
ok      github.com/hashicorp/terraform-provider-google-beta/google-beta 416.780s

modular-magician · 2023-01-19T04:24:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-19T05:17:14Z

Tests analytics

Total tests: 2424
Passed tests 2166
Skipped tests: 253
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIIndex_updated|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-19T05:55:44Z

Tests passed during RECORDING mode:
TestAccVertexAIIndex_updated[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-20T03:32:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-20T04:21:55Z

Tests analytics

Total tests: 2423
Passed tests 2169
Skipped tests: 253
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-20T04:24:46Z

Tests failed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-20T17:12:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-20T18:01:16Z

Tests analytics

Total tests: 2423
Passed tests 2167
Skipped tests: 253
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-20T18:04:56Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-21T06:56:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-21T07:42:25Z

Tests analytics

Total tests: 2423
Passed tests 2167
Skipped tests: 253
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccComputeForwardingRule_update|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-21T07:46:07Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick · 2023-01-24T00:23:04Z

Requesting review from @melinath who reverted the previous PR

modular-magician · 2023-01-24T03:00:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-01-24T03:46:37Z

Tests analytics

Total tests: 2425
Passed tests 2170
Skipped tests: 254
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2023-01-24T03:47:06Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

melinath

overall this LGTM - one change request below.

mmv1/third_party/terraform/tests/resource_compute_region_instance_group_manager_test.go.erb

This reverts commit 4ec92c3.

modular-magician · 2023-01-28T08:16:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 1 file changed, 7 insertions(+))

modular-magician · 2023-01-28T08:58:16Z

Tests analytics

Total tests: 2439
Passed tests 2182
Skipped tests: 254
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-28T09:12:49Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-28T10:28:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 1 file changed, 7 insertions(+))

modular-magician · 2023-01-28T11:14:56Z

Tests analytics

Total tests: 2439
Passed tests 2183
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-28T11:15:28Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_failedCreation[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

LGTM - this isn't currently caught by automation but I've confirmed the "region" field exists, and the tests aren't crashing, so it should be fine. The tests will start getting run as part of #7185 or #6580

melinath · 2023-01-30T22:01:31Z

failed test looks unrelated

…rm#7137) * fix: datacatalog taxonomy import project from name Signed-off-by: ekapratama93 <[email protected]> * fix: indentation on region instance group manager test Signed-off-by: ekapratama93 <[email protected]> * Revert "fix: indentation on region instance group manager test" This reverts commit 4ec92c3. --------- Signed-off-by: ekapratama93 <[email protected]>

fix: datacatalog taxonomy import project from name

425288f

Signed-off-by: ekapratama93 <[email protected]>

modular-magician requested a review from slevenick January 18, 2023 10:10

fix: indentation on region instance group manager test

4ec92c3

Signed-off-by: ekapratama93 <[email protected]>

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

daf3a00

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

dd8516a

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

b0bbe0d

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

7ea51c5

slevenick requested a review from melinath January 24, 2023 00:22

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

e3352a3

melinath requested changes Jan 26, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_region_instance_group_manager_test.go.erb Outdated Show resolved Hide resolved

Revert "fix: indentation on region instance group manager test"

e6bc35e

This reverts commit 4ec92c3.

ekapratama93 requested review from melinath and removed request for slevenick January 28, 2023 08:01

Merge branch 'GoogleCloudPlatform:main' into fix/dc-taxonomy

434f8db

melinath approved these changes Jan 30, 2023

View reviewed changes

melinath merged commit 3bc9fa3 into GoogleCloudPlatform:main Jan 30, 2023

melinath mentioned this pull request Jan 30, 2023

datacatalog - bump Taxonomy and PolicyTag to ga #6989

Merged

5 tasks

This was referenced Jan 30, 2023

fix: datacatalog taxonomy import project from name hashicorp/terraform-provider-google-beta#5145

Merged

fix: datacatalog taxonomy import project from name GoogleCloudPlatform/terraform-validator#1324

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: datacatalog taxonomy import project from name #7137

fix: datacatalog taxonomy import project from name #7137

ekapratama93 commented Jan 18, 2023 •

edited

Loading

google-cla bot commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

ekapratama93 commented Jan 18, 2023 •

edited

Loading

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

modular-magician commented Jan 21, 2023

modular-magician commented Jan 21, 2023

modular-magician commented Jan 21, 2023

slevenick commented Jan 24, 2023

modular-magician commented Jan 24, 2023

modular-magician commented Jan 24, 2023

modular-magician commented Jan 24, 2023

melinath left a comment

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

melinath left a comment •

edited

Loading

melinath commented Jan 30, 2023

fix: datacatalog taxonomy import project from name #7137

fix: datacatalog taxonomy import project from name #7137

Conversation

ekapratama93 commented Jan 18, 2023 • edited Loading

google-cla bot commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

Diff report

modular-magician commented Jan 18, 2023

Tests analytics

Action taken

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

Diff report

modular-magician commented Jan 18, 2023

Tests analytics

Action taken

modular-magician commented Jan 18, 2023

ekapratama93 commented Jan 18, 2023 • edited Loading

modular-magician commented Jan 19, 2023

Diff report

modular-magician commented Jan 19, 2023

Tests analytics

Action taken

modular-magician commented Jan 19, 2023

modular-magician commented Jan 20, 2023

Diff report

modular-magician commented Jan 20, 2023

Tests analytics

Action taken

modular-magician commented Jan 20, 2023

modular-magician commented Jan 20, 2023

Diff report

modular-magician commented Jan 20, 2023

Tests analytics

Action taken

modular-magician commented Jan 20, 2023

modular-magician commented Jan 21, 2023

Diff report

modular-magician commented Jan 21, 2023

Tests analytics

Action taken

modular-magician commented Jan 21, 2023

slevenick commented Jan 24, 2023

modular-magician commented Jan 24, 2023

Diff report

modular-magician commented Jan 24, 2023

Tests analytics

Action taken

modular-magician commented Jan 24, 2023

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Jan 28, 2023

Diff report

modular-magician commented Jan 28, 2023

Tests analytics

Action taken

modular-magician commented Jan 28, 2023

modular-magician commented Jan 28, 2023

Diff report

modular-magician commented Jan 28, 2023

Tests analytics

Action taken

modular-magician commented Jan 28, 2023

melinath left a comment • edited Loading

Choose a reason for hiding this comment

melinath commented Jan 30, 2023

ekapratama93 commented Jan 18, 2023 •

edited

Loading

ekapratama93 commented Jan 18, 2023 •

edited

Loading

melinath left a comment •

edited

Loading