Add stateful_ips to region_per_instance_config and per_instance_config #7316

hao-nan-li · 2023-02-16T23:27:40Z

Add stateful_ips to region_per_instance_config and per_instance_config

https://cloud.google.com/compute/docs/reference/rest/beta/instanceGroupManagers/createInstances

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `internal_ip` and `external_ip` to `google_compute_per_instance_config` and `google_compute_region_per_instance_config` (beta)

modular-magician · 2023-02-16T23:43:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 502 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1110 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

ScottSuarez · 2023-02-16T23:55:56Z

rerolling since I'm going to oof tmrw and tuesday

modular-magician · 2023-02-17T00:25:53Z

Tests analytics

Total tests: 2469
Passed tests 2209
Skipped tests: 256
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_statefulIps|TestAccComputeForwardingRule_update

modular-magician · 2023-02-17T00:29:08Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputePerInstanceConfig_statefulIps[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/compute/api.yaml

modular-magician · 2023-02-17T18:00:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 492 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1084 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-17T18:43:01Z

Tests analytics

Total tests: 2469
Passed tests 2211
Skipped tests: 256
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_statefulIps

modular-magician · 2023-02-17T18:48:53Z

Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/third_party/terraform/tests/resource_compute_per_instance_config_test.go

mmv1/third_party/terraform/tests/resource_compute_region_per_instance_config_test.go

shuyama1 · 2023-02-21T17:16:14Z

mmv1/products/compute/api.yaml

+            name: 'internalIp'
+            api_name: internalIPs
+            min_version: beta
+            key_name: "interface_name"


Do we want to add key_description here which will add a description for the field interface_name in doc? Current description is "interface_name - (Required) The identifier for this object. Format specified above". I wonder if we want to change it.

I don't see a clean description on the GCP public doc, perhaps the current description is good enough.

mmv1/products/compute/terraform.yaml

modular-magician · 2023-02-21T18:53:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 492 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1084 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-21T19:40:48Z

Tests analytics

Total tests: 2474
Passed tests 2211
Skipped tests: 256
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccDNSRecordSet_changeRouting|TestAccDNSRecordSet_routingPolicy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_statefulIps|TestAccApigeeAddonsConfig_apigeeAddonsTestExample

modular-magician · 2023-02-21T19:52:58Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDNSRecordSet_changeRouting[Debug log]
TestAccDNSRecordSet_routingPolicy[Debug log]
TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log]
TestAccComputePerInstanceConfig_statefulIps[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

shuyama1

Would you mind rebasing your PR? Thanks!

shuyama1 · 2023-02-27T17:46:16Z

/gcbrun

modular-magician · 2023-02-27T18:02:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 492 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1084 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-02-27T18:49:49Z

Tests analytics

Total tests: 2475
Passed tests 2217
Skipped tests: 255
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-27T19:41:08Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2023-02-27T19:51:23Z

@hao-nan-li failing test is unrelated. Feel free to merge

GoogleCloudPlatform#7316) * Add stateful_ips to region_per_instance_config and per_instance_config * Change network resource name to random strings * Update update tests, remove is_set for stateful_ips

* main: (41 commits) update the test cases to resolve resourcename not found error Adds `grpc` field to `liveness_probe` and `startup_probe` to `google_cloud_run_v2_service` resource (GoogleCloudPlatform#6987) Upgrade DCL to v1.34 (GoogleCloudPlatform#7276) Add max_distance field to group placement policy (GoogleCloudPlatform#7354) Add stateful_ips to region_per_instance_config and per_instance_config (GoogleCloudPlatform#7316) Added support for workload-vulnerability-scanning and workload-config-audit (GoogleCloudPlatform#7310) datacatalog - bump Taxonomy and PolicyTag to ga (GoogleCloudPlatform#6989) Added best practices documentation for ForceNew fields (GoogleCloudPlatform#7127) Split resources in "B" products (GoogleCloudPlatform#7350) force recreate on master_config.num_instances (GoogleCloudPlatform#7349) Fix DataFusion instance versions used in tests (GoogleCloudPlatform#7343) remove duplicate word in Cluster.yaml (GoogleCloudPlatform#7347) Move more billing tests that require permissions beyond Billing User to master billing account (GoogleCloudPlatform#7344) Remove artifact repository beta URL, fixup handwritten tests (GoogleCloudPlatform#7345) Cloud Workstations - Workstation Config (GoogleCloudPlatform#7017) Add missing `type` argument to data source docs (GoogleCloudPlatform#7341) Fix caps in spanner resource schema accesses (GoogleCloudPlatform#7346) Downgrade Go to 1.18, modify comments (GoogleCloudPlatform#7339) feat: Add support for deletion_policy on shared vpc service project (GoogleCloudPlatform#7283) fixed virtual field update issues (GoogleCloudPlatform#7318) ...

GoogleCloudPlatform#7316) * Add stateful_ips to region_per_instance_config and per_instance_config * Change network resource name to random strings * Update update tests, remove is_set for stateful_ips

Add stateful_ips to region_per_instance_config and per_instance_config

51994ed

hao-nan-li requested a review from a team as a code owner February 16, 2023 23:27

hao-nan-li requested review from ScottSuarez and removed request for a team February 16, 2023 23:27

hao-nan-li mentioned this pull request Feb 16, 2023

[WIP] Initial Commit to add statefulIps and tests for perInstanceConfig #7302

Closed

5 tasks

ScottSuarez requested review from a team and removed request for ScottSuarez February 16, 2023 23:55

ScottSuarez requested review from a team and shuyama1 and removed request for a team February 17, 2023 00:34

askubis reviewed Feb 17, 2023

View reviewed changes

mmv1/products/compute/api.yaml Outdated Show resolved Hide resolved

askubis reviewed Feb 17, 2023

View reviewed changes

mmv1/products/compute/api.yaml Outdated Show resolved Hide resolved

Change network resource name to random strings

0316879

shuyama1 reviewed Feb 21, 2023

View reviewed changes

Update update tests, remove is_set for stateful_ips

8e695a2

hao-nan-li requested a review from shuyama1 February 21, 2023 21:04

shuyama1 approved these changes Feb 27, 2023

View reviewed changes

hao-nan-li merged commit 4c8e892 into GoogleCloudPlatform:main Feb 27, 2023

hao-nan-li mentioned this pull request Feb 28, 2023

Stateful IP Support in Per Instance Config Resources hashicorp/terraform-provider-google#13399

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stateful_ips to region_per_instance_config and per_instance_config #7316

Add stateful_ips to region_per_instance_config and per_instance_config #7316

hao-nan-li commented Feb 16, 2023 •

edited by shuyama1

Loading

modular-magician commented Feb 16, 2023

ScottSuarez commented Feb 16, 2023

modular-magician commented Feb 17, 2023

modular-magician commented Feb 17, 2023

modular-magician commented Feb 17, 2023

modular-magician commented Feb 17, 2023

modular-magician commented Feb 17, 2023

shuyama1 Feb 21, 2023

hao-nan-li Feb 21, 2023

modular-magician commented Feb 21, 2023

modular-magician commented Feb 21, 2023

modular-magician commented Feb 21, 2023

shuyama1 left a comment •

edited

Loading

shuyama1 commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

shuyama1 commented Feb 27, 2023

Add stateful_ips to region_per_instance_config and per_instance_config #7316

Add stateful_ips to region_per_instance_config and per_instance_config #7316

Conversation

hao-nan-li commented Feb 16, 2023 • edited by shuyama1 Loading

modular-magician commented Feb 16, 2023

Diff report

ScottSuarez commented Feb 16, 2023

modular-magician commented Feb 17, 2023

Tests analytics

Action taken

modular-magician commented Feb 17, 2023

modular-magician commented Feb 17, 2023

Diff report

modular-magician commented Feb 17, 2023

Tests analytics

Action taken

modular-magician commented Feb 17, 2023

shuyama1 Feb 21, 2023

Choose a reason for hiding this comment

hao-nan-li Feb 21, 2023

Choose a reason for hiding this comment

modular-magician commented Feb 21, 2023

Diff report

modular-magician commented Feb 21, 2023

Tests analytics

Action taken

modular-magician commented Feb 21, 2023

shuyama1 left a comment • edited Loading

Choose a reason for hiding this comment

shuyama1 commented Feb 27, 2023

modular-magician commented Feb 27, 2023

Diff report

modular-magician commented Feb 27, 2023

Tests analytics

Action taken

modular-magician commented Feb 27, 2023

shuyama1 commented Feb 27, 2023

hao-nan-li commented Feb 16, 2023 •

edited by shuyama1

Loading

shuyama1 left a comment •

edited

Loading