Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perma diff problem during TF import #7348

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

hao-nan-li
Copy link
Contributor

@hao-nan-li hao-nan-li commented Feb 24, 2023

fixes hashicorp/terraform-provider-google#13515
TLDR: Resource groups has a field initialGroupConfig and the default value is "EMPTY". During a TF import, this field is not set to "EMPTY" if it has no value.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudidentity: fixed an issue on `initialGroupConfig` field when users make an import.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2473
Passed tests 2215
Skipped tests: 255
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]

All tests passed
View the build log or the debug log for each test

@hao-nan-li hao-nan-li marked this pull request as ready for review February 24, 2023 20:31
@hao-nan-li hao-nan-li requested a review from a team as a code owner February 24, 2023 20:31
@hao-nan-li hao-nan-li requested review from roaks3 and removed request for a team February 24, 2023 20:31
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One note on the PR description, it seems like this might fix the issue you referenced. If it does, I think you need to include fixes or closes.

@hao-nan-li
Copy link
Contributor Author

LGTM

One note on the PR description, it seems like this might fix the issue you referenced. If it does, I think you need to include fixes or closes.

Thanks, will do.

@dawnbreak
Copy link

I am not sure if this is really solved. I have Terraform 1.5.7 and google provider 5.7.0. I have exactly the same issue that after an import of a google_cloud_identity_group the value initial_group_config is not set and terraform plan shows this change.

@roaks3
Copy link
Contributor

roaks3 commented Nov 21, 2023

@dawnbreak Could you please open a new issue for the problem your experiencing? You can reference this PR and the original issue there, and that will give us a place to triage/discuss/etc.

@nathou
Copy link

nathou commented May 3, 2024

FYI @dawnbreak the fix seems to only have lasted until google provider version 4.61.0.
Version 4.62.0 has the initialGroupConfig setting forcing replacement of group again after import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider tries to incorrectly set initial_group_config after import of google_cloud_identity_group
5 participants