-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix perma diff problem during TF import #7348
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 4 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One note on the PR description, it seems like this might fix the issue you referenced. If it does, I think you need to include fixes
or closes
.
Thanks, will do. |
I am not sure if this is really solved. I have Terraform 1.5.7 and google provider 5.7.0. I have exactly the same issue that after an import of a |
@dawnbreak Could you please open a new issue for the problem your experiencing? You can reference this PR and the original issue there, and that will give us a place to triage/discuss/etc. |
FYI @dawnbreak the fix seems to only have lasted until google provider version 4.61.0. |
fixes hashicorp/terraform-provider-google#13515
TLDR: Resource
groups
has a fieldinitialGroupConfig
and the default value is "EMPTY". During a TF import, this field is not set to "EMPTY" if it has no value.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)